Changeset 12679 for trunk/tests/phpunit/testcases/members/functions.php

Timestamp:

07/04/2020 01:29:50 PM (5 years ago)

Author:

imath

Message:

BP Members: improve our password validation process

We're introducing a new function to validate the member's chosen password: bp_members_validate_user_password().

This function is primarly used to check the password is not empty, and to make sure the password confirmation matches the password. If it's the case, the function will return a WP_Error object with no error message. Otherwise this object will contain an error message.

Plugins can now use the bp_members_validate_user_password filter to add their own error messages according to a custom validation process. See the last unit tests of this commit for an example of use.

Props devnik, tharsheblows

Fixes #8066

File:

• trunk/tests/phpunit/testcases/members/functions.php (modified) (1 diff)

trunk/tests/phpunit/testcases/members/functions.php

@@ -579 +579 @@
     public function test_wp_registration_url_should_return_bp_register_page_when_register_page_is_configured_properly() {
         $this->assertSame( bp_get_signup_page(), wp_registration_url() );
+    }
+
+    /**
+     * @group bp_members_validate_user_password
+     */
+    public function test_bp_members_validate_user_password() {
+        $validate = bp_members_validate_user_password( 'foobar', 'foobar' );
+
+        $this->assertEmpty( $validate->get_error_message() );
+    }
+
+    /**
+     * @group bp_members_validate_user_password
+     */
+    public function test_bp_members_validate_user_password_missing() {
+        $validate = bp_members_validate_user_password( '', '' );
+
+        $this->assertEquals( 'missing_user_password', $validate->get_error_code() );
+
+        $validate = bp_members_validate_user_password( 'foobar', '' );
+
+        $this->assertEquals( 'missing_user_password', $validate->get_error_code() );
+
+        $validate = bp_members_validate_user_password( '', 'foobar' );
+
+        $this->assertEquals( 'missing_user_password', $validate->get_error_code() );
+    }
+
+    /**
+     * @group bp_members_validate_user_password
+     */
+    public function test_bp_members_validate_user_password_mismatching() {
+        $validate = bp_members_validate_user_password( 'foobar', 'barfoo' );
+
+        $this->assertEquals( 'mismatching_user_password', $validate->get_error_code() );
+    }
+
+    /**
+     * @group bp_members_validate_user_password
+     */
+    public function test_bp_members_validate_user_password_too_short() {
+        add_filter( 'bp_members_validate_user_password', array( $this, 'filter_bp_members_validate_user_password' ), 10, 2 );
+
+        $validate = bp_members_validate_user_password( 'one', 'one' );
+
+        remove_filter( 'bp_members_validate_user_password', array( $this, 'filter_bp_members_validate_user_password' ), 10, 2 );
+
+        $this->assertEquals( 'too_short_user_password', $validate->get_error_code() );
+    }
+
+    function filter_bp_members_validate_user_password( $errors, $pass ) {
+        if ( 4 > strlen( $pass ) ) {
+            $errors->add( 'too_short_user_password', __( 'Your password is too short.', 'buddypress' ) );
+        }
+
+        return $errors;
     }