Changeset 12647

Timestamp:

05/07/2020 07:23:00 PM (5 years ago)

Author:

r-a-y

Message:

Do not use sanitize_file_name() when passing integer values.

Fixes an array offset notice due to the addition of seems_utf8() in
sanitize_file_name() for WordPress 5.4.1:
​https://core.trac.wordpress.org/changeset/47643

Props mercime, r-a-y.

Fixes #8288.

Location:

trunk/src

Files:

• bp-groups/bp-groups-template.php (modified) (1 diff)
• bp-groups/classes/class-bp-groups-theme-compat.php (modified) (1 diff)
• bp-members/bp-members-template.php (modified) (1 diff)
• bp-members/classes/class-bp-members-theme-compat.php (modified) (1 diff)
• bp-templates/bp-nouveau/includes/groups/functions.php (modified) (1 diff)
• bp-templates/bp-nouveau/includes/members/functions.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-template.php

@@ -4359 +4359 @@
 
     $template_names = array(
-        'groups/single/front-id-'     . sanitize_file_name( $group->id )     . '.php',
+        'groups/single/front-id-'     . (int) $group->id . '.php',
         'groups/single/front-slug-'   . sanitize_file_name( $group->slug )   . '.php',
     );

trunk/src/bp-groups/classes/class-bp-groups-theme-compat.php

@@ -224 +224 @@
          */
         $new_templates = apply_filters( 'bp_template_hierarchy_groups_single_item', array(
-            'groups/single/index-id-'     . sanitize_file_name( bp_get_current_group_id() )   . '.php',
+            'groups/single/index-id-'     . (int) bp_get_current_group_id()                   . '.php',
             'groups/single/index-slug-'   . sanitize_file_name( bp_get_current_group_slug() ) . '.php',
             'groups/single/index-action-' . sanitize_file_name( bp_current_action() )         . '.php',

trunk/src/bp-members/bp-members-template.php

@@ -1424 +1424 @@
     // Init the hierarchy
     $template_names = array(
-        'members/single/front-id-' . sanitize_file_name( $displayed_user->id ) . '.php',
+        'members/single/front-id-' . (int) $displayed_user->id . '.php',
         'members/single/front-nicename-' . sanitize_file_name( $displayed_user->userdata->user_nicename ) . '.php',
     );

trunk/src/bp-members/classes/class-bp-members-theme-compat.php

@@ -171 +171 @@
          */
         $new_templates = apply_filters( 'bp_template_hierarchy_members_single_item', array(
-            'members/single/index-id-'        . sanitize_file_name( bp_displayed_user_id() ) . '.php',
+            'members/single/index-id-'        . (int) bp_displayed_user_id()                 . '.php',
             'members/single/index-nicename-'  . sanitize_file_name( $user_nicename )         . '.php',
             'members/single/index-action-'    . sanitize_file_name( bp_current_action() )    . '.php',

trunk/src/bp-templates/bp-nouveau/includes/groups/functions.php

@@ -941 +941 @@
     if ( ! isset( $bp_nouveau->groups->current_group_hierarchy ) ) {
         $bp_nouveau->groups->current_group_hierarchy = array(
-            'groups/single/%s-id-' . sanitize_file_name( $current_group->id ) . '.php',
+            'groups/single/%s-id-' . (int) $current_group->id                     . '.php',
             'groups/single/%s-slug-' . sanitize_file_name( $current_group->slug ) . '.php',
         );

trunk/src/bp-templates/bp-nouveau/includes/members/functions.php

@@ -265 +265 @@
     if ( ! isset( $bp_nouveau->members->displayed_user_hierarchy ) ) {
         $bp_nouveau->members->displayed_user_hierarchy = array(
-            'members/single/%s-id-' . sanitize_file_name( $displayed_user->id ) . '.php',
+            'members/single/%s-id-' . (int) $displayed_user->id . '.php',
             'members/single/%s-nicename-' . sanitize_file_name( $displayed_user->userdata->user_nicename ) . '.php',
         );