Changeset 12602

Timestamp:

03/28/2020 09:21:09 PM (6 years ago)

Author:

boonebgorges

Message:

isset() checks for a variety of variable references.

This helps to avoid PHP notices in 7.4+.

See #8264.

Location:

trunk/src

Files:

• bp-activity/bp-activity-functions.php (modified) (1 diff)
• bp-core/classes/class-bp-attachment-cover-image.php (modified) (1 diff)
• bp-core/classes/class-bp-media-extractor.php (modified) (1 diff)
• bp-core/classes/class-bp-user-query.php (modified) (1 diff)
• bp-friends/bp-friends-activity.php (modified) (1 diff)
• bp-members/bp-members-functions.php (modified) (1 diff)
• bp-messages/classes/class-bp-messages-box-template.php (modified) (1 diff)
• bp-notifications/bp-notifications-functions.php (modified) (1 diff)

trunk/src/bp-activity/bp-activity-functions.php

@@ -3429 +3429 @@
         $summary .= PHP_EOL . PHP_EOL . $extracted_media['url'];
     } elseif ( $use_media_type === 'images' ) {
-        $summary .= sprintf( ' <img src="%s">', esc_url( $extracted_media['url'] ) );
+        $extracted_media_url = isset( $extracted_media['url'] ) ? $extracted_media['url'] : '';
+        $summary .= sprintf( ' <img src="%s">', esc_url( $extracted_media_url ) );
     } elseif ( in_array( $use_media_type, array( 'audio', 'videos' ), true ) ) {
         $summary .= PHP_EOL . PHP_EOL . $extracted_media['original'];  // Full shortcode.

trunk/src/bp-core/classes/class-bp-attachment-cover-image.php

@@ -79 +79 @@
 
         // File size is too big.
-        if ( $file['size'] > $this->original_max_filesize ) {
+        if ( isset( $file['size'] ) && ( $file['size'] > $this->original_max_filesize ) ) {
             $file['error'] = 11;
 
         // File is of invalid type.
-        } elseif ( ! bp_attachments_check_filetype( $file['tmp_name'], $file['name'], bp_attachments_get_allowed_mimes( 'cover_image' ) ) ) {
+        } elseif ( isset( $file['tmp_name'] ) && isset( $file['name'] ) && ! bp_attachments_check_filetype( $file['tmp_name'], $file['name'], bp_attachments_get_allowed_mimes( 'cover_image' ) ) ) {
             $file['error'] = 12;
         }

trunk/src/bp-core/classes/class-bp-media-extractor.php

@@ -826 +826 @@
                 foreach ( $images as $image_id ) {
                     $image  = wp_get_attachment_image_src( $image_id, $image_size );
+
+                    $image_url    = isset( $image[0] ) ? $image[0] : '';
+                    $image_width  = isset( $image[1] ) ? $image[1] : '';
+                    $image_height = isset( $image[2] ) ? $image[2] : '';
+
                     $data[] = array(
-                        'url'    => $image[0],
-                        'width'  => $image[1],
-                        'height' => $image[2],
+                        'url'    => $image_url,
+                        'width'  => $image_width,
+                        'height' => $image_height,
 
                         'gallery_id' => 1 + $gallery_id,

trunk/src/bp-core/classes/class-bp-user-query.php

@@ -685 +685 @@
         // Set a last_activity value for each user, even if it's empty.
         foreach ( $this->results as $user_id => $user ) {
-            $user_last_activity = isset( $last_activities[ $user_id ] ) ? $last_activities[ $user_id ]['date_recorded'] : '';
+            $user_last_activity = isset( $last_activities[ $user_id ]['date_recorded'] ) ? $last_activities[ $user_id ]['date_recorded'] : '';
             $this->results[ $user_id ]->last_activity = $user_last_activity;
         }

trunk/src/bp-friends/bp-friends-activity.php

@@ -313 +313 @@
 
     // Get the requested action.
-    $action = $filter['filter']['action'];
+    $action = isset( $filter['filter']['action'] ) ? $filter['filter']['action'] : array();
 
     // Make sure actions are listed in an array.

trunk/src/bp-members/bp-members-functions.php

@@ -1924 +1924 @@
         $user = array(
             'user_id'  => $user_id,
-            'password' => $signup->meta['password'],
+            'password' => isset( $signup->meta['password'] ) ? $signup->meta['password'] : '',
             'meta'     => $signup->meta,
         );

trunk/src/bp-messages/classes/class-bp-messages-box-template.php

@@ -163 +163 @@
             ) );
 
-            $this->threads            = $threads['threads'];
-            $this->total_thread_count = $threads['total'];
+            $this->threads            = isset( $threads['threads'] ) ? $threads['threads'] : array();
+            $this->total_thread_count = isset( $threads['total'] ) ? $threads['total'] : 0;
         }
 

trunk/src/bp-notifications/bp-notifications-functions.php

@@ -234 +234 @@
                     $notification_object->href    = bp_loggedin_user_domain();
                 } else {
-                    $notification_object->content = $content['text'];
-                    $notification_object->href    = $content['link'];
+                    $notification_object->content = isset( $content['text'] ) ? $content['text'] : '';
+                    $notification_object->href    = isset( $content['link'] ) ? $content['link'] : '';
                 }