Changeset 12495

Timestamp:

11/07/2019 07:00:08 PM (7 years ago)

Author:

imath

Message:

Use WP_Admin_Bar::add_node() to create new WP Admin Bar menu items

WP_Admin_Bar::add_menu() has been deprecated in WordPress 5.4. As this WP_Admin_Bar method is a wrapper of WP_Admin_Bar::add_node() since the introduction of the WP Admin Bar into WordPress 3.3 we can safely do this move.

Fixes #8158

Location:

trunk/src

Files:

• bp-activity/bp-activity-adminbar.php (modified) (1 diff)
• bp-core/bp-core-adminbar.php (modified) (1 diff)
• bp-core/classes/class-bp-admin.php (modified) (1 diff)
• bp-core/classes/class-bp-component.php (modified) (1 diff)
• bp-groups/bp-groups-adminbar.php (modified) (2 diffs)
• bp-members/bp-members-adminbar.php (modified) (9 diffs)
• bp-notifications/bp-notifications-adminbar.php (modified) (3 diffs)

trunk/src/bp-activity/bp-activity-adminbar.php

@@ -39 +39 @@
 
         // Add the top-level Edit Activity button.
-        $wp_admin_bar->add_menu( array(
+        $wp_admin_bar->add_node( array(
                 'id'    => 'activity-admin',
                 'title' => __( 'Edit Activity', 'buddypress' ),

trunk/src/bp-core/bp-core-adminbar.php

@@ -31 +31 @@
 
                 // Add secondary parent item for all BuddyPress components.
-                $wp_admin_bar->add_menu( array(
+                $wp_admin_bar->add_node( array(
                         'parent'    => 'my-account',
                         'id'        => 'my-account-buddypress',

trunk/src/bp-core/classes/class-bp-admin.php

@@ -475 +475 @@
                 }
 
-                $wp_admin_bar->add_menu( array(
+                $wp_admin_bar->add_node( array(
                         'parent' => 'wp-logo',
                         'id'     => 'bp-about',

trunk/src/bp-core/classes/class-bp-component.php

@@ -597 +597 @@
                         // Add each admin menu.
                         foreach( $this->admin_menu as $admin_menu ) {
-                                $wp_admin_bar->add_menu( $admin_menu );
+                                $wp_admin_bar->add_node( $admin_menu );
                         }
                 }

trunk/src/bp-groups/bp-groups-adminbar.php

@@ -41 +41 @@
 
         // Add the top-level Group Admin button.
-        $wp_admin_bar->add_menu( array(
+        $wp_admin_bar->add_node( array(
                 'id'    => $bp->group_admin_menu_id,
                 'title' => __( 'Edit Group', 'buddypress' ),
@@ -72 +72 @@
                         }
 
-                        $wp_admin_bar->add_menu( array(
+                        $wp_admin_bar->add_node( array(
                                 'parent' => $bp->group_admin_menu_id,
                                 'id'     => $menu->slug,

trunk/src/bp-members/bp-members-adminbar.php

@@ -36 +36 @@
 
                 // Create the main 'My Account' menu.
-                $wp_admin_bar->add_menu( array(
+                $wp_admin_bar->add_node( array(
                         'id'     => $bp->my_account_menu_id,
                         'group'  => true,
@@ -51 +51 @@
 
                 // Create the main 'My Account' menu.
-                $wp_admin_bar->add_menu( array(
+                $wp_admin_bar->add_node( array(
                         'id'    => 'bp-login',
                         'title' => __( 'Log In', 'buddypress' ),
@@ -59 +59 @@
                 // Sign up.
                 if ( bp_get_signup_allowed() ) {
-                        $wp_admin_bar->add_menu( array(
+                        $wp_admin_bar->add_node( array(
                                 'id'    => 'bp-register',
                                 'title' => __( 'Register', 'buddypress' ),
@@ -91 +91 @@
 
         // Add the top-level User Admin button.
-        $wp_admin_bar->add_menu( array(
+        $wp_admin_bar->add_node( array(
                 'id'    => $bp->user_admin_menu_id,
                 'title' => __( 'Edit Member', 'buddypress' ),
@@ -99 +99 @@
         if ( bp_is_active( 'xprofile' ) ) {
                 // User Admin > Edit this user's profile.
-                $wp_admin_bar->add_menu( array(
+                $wp_admin_bar->add_node( array(
                         'parent' => $bp->user_admin_menu_id,
                         'id'     => $bp->user_admin_menu_id . '-edit-profile',
@@ -108 +108 @@
                 // User Admin > Edit this user's avatar.
                 if ( buddypress()->avatar->show_avatars ) {
-                        $wp_admin_bar->add_menu( array(
+                        $wp_admin_bar->add_node( array(
                                 'parent' => $bp->user_admin_menu_id,
                                 'id'     => $bp->user_admin_menu_id . '-change-avatar',
@@ -118 +118 @@
                 // User Admin > Edit this user's cover image.
                 if ( bp_displayed_user_use_cover_image_header() ) {
-                        $wp_admin_bar->add_menu( array(
+                        $wp_admin_bar->add_node( array(
                                 'parent' => $bp->user_admin_menu_id,
                                 'id'     => $bp->user_admin_menu_id . '-change-cover-image',
@@ -130 +130 @@
         if ( bp_is_active( 'settings' ) ) {
                 // User Admin > Spam/unspam.
-                $wp_admin_bar->add_menu( array(
+                $wp_admin_bar->add_node( array(
                         'parent' => $bp->user_admin_menu_id,
                         'id'     => $bp->user_admin_menu_id . '-user-capabilities',
@@ -138 +138 @@
 
                 // User Admin > Delete Account.
-                $wp_admin_bar->add_menu( array(
+                $wp_admin_bar->add_node( array(
                         'parent' => $bp->user_admin_menu_id,
                         'id'     => $bp->user_admin_menu_id . '-delete-user',

trunk/src/bp-notifications/bp-notifications-adminbar.php

@@ -34 +34 @@
 
         // Add the top-level Notifications button.
-        $wp_admin_bar->add_menu( array(
+        $wp_admin_bar->add_node( array(
                 'parent'    => 'top-secondary',
                 'id'        => 'bp-notifications',
@@ -43 +43 @@
         if ( ! empty( $notifications ) ) {
                 foreach ( (array) $notifications as $notification ) {
-                        $wp_admin_bar->add_menu( array(
+                        $wp_admin_bar->add_node( array(
                                 'parent' => 'bp-notifications',
                                 'id'     => 'notification-' . $notification->id,
@@ -51 +51 @@
                 }
         } else {
-                $wp_admin_bar->add_menu( array(
+                $wp_admin_bar->add_node( array(
                         'parent' => 'bp-notifications',
                         'id'     => 'no-notifications',