Changeset 12491 for branches/5.0/src/bp-core/admin/bp-core-admin-functions.php

Timestamp:

11/01/2019 04:20:23 AM (5 years ago)

Author:

imath

Message:

Edit the type of the bp_block_category() function's second argument

Although this filter should always get a WP_Post as a second argument, it appears there is a risk this function is used directly passing a null value as the second argument. See this ​support topic.

To prevent this risk of notice error, we are making sure the second argument is a WP_Post in a different way.

Fixes #8152 (Branch 5.0)

File:

• branches/5.0/src/bp-core/admin/bp-core-admin-functions.php (modified) (1 diff)

branches/5.0/src/bp-core/admin/bp-core-admin-functions.php

@@ -1143 +1143 @@
  *
  * @param array   $categories Array of block categories.
- * @param WP_Post $post       Post being loaded.
- */
-function bp_block_category( $categories = array(), WP_Post $post ) {
+ * @param object  $post       Post being loaded.
+ */
+function bp_block_category( $categories = array(), $post = null ) {
+    if ( ! ( $post instanceof WP_Post ) ) {
+        return $categories;
+    }
+
     /**
      * Filter here to add/remove the supported post types for the BuddyPress blocks category.