Changeset 12450 for trunk/tests/phpunit/testcases/members/functions.php

Timestamp:

08/24/2019 02:53:10 PM (6 years ago)

Author:

imath

Message:

Anticipate the deprecation in WordPress 5.3 of update_user_status()

Introduce bp_core_update_member_status() in order to wrap wp_update_user() with needed argument to spam a user on multisite configurations.

Props espellcaste

Fixes #8123

File:

• trunk/tests/phpunit/testcases/members/functions.php (modified) (8 diffs)

trunk/tests/phpunit/testcases/members/functions.php

@@ -379 +379 @@
         }
 
-        if ( is_multisite() && function_exists( 'wp_get_registered_image_subsizes' ) ) {
-            $this->setExpectedDeprecated( 'update_user_status' );
-        }
-
         $bp = buddypress();
         $displayed_user = $bp->displayed_user;
@@ -390 +386 @@
 
         // Bulk spam in network admin uses update_user_status
-        update_user_status( $u1, 'spam', '1' );
+        bp_core_update_member_status( $u1, '1' );
 
         $this->assertTrue( bp_is_user_spammer( $u1 ) );
@@ -411 +407 @@
         }
 
-        if ( is_multisite() && function_exists( 'wp_get_registered_image_subsizes' ) ) {
-            $this->setExpectedDeprecated( 'update_user_status' );
-        }
-
         $bp = buddypress();
         $displayed_user = $bp->displayed_user;
@@ -427 +419 @@
 
         // Bulk unspam in network admin uses update_user_status
-        update_user_status( $u1, 'spam', '0' );
+        bp_core_update_member_status( $u1, '0' );
 
         $this->assertFalse( bp_is_user_spammer( $u1 ) );
@@ -439 +431 @@
      */
     public function test_bp_core_process_spammer_status_make_spam_user_filter() {
-        if ( is_multisite() && function_exists( 'wp_get_registered_image_subsizes' ) ) {
-            $this->setExpectedDeprecated( 'update_user_status' );
-        }
-
         add_filter( 'make_spam_user', array( $this, 'notification_filter_callback' ) );
 
@@ -455 +443 @@
 
     public function test_bp_core_process_spammer_status_make_ham_user_filter() {
-        if ( is_multisite() && function_exists( 'wp_get_registered_image_subsizes' ) ) {
-            $this->setExpectedDeprecated( 'update_user_status' );
-        }
+        $u1 = self::factory()->user->create();
+        $s  = bp_core_process_spammer_status( $u1, 'spam' );
 
         add_filter( 'make_ham_user', array( $this, 'notification_filter_callback' ) );
 
-        $u1 = self::factory()->user->create();
-        $n = bp_core_process_spammer_status( $u1, 'ham' );
+        $h = bp_core_process_spammer_status( $u1, 'ham' );
 
         remove_filter( 'make_ham_user', array( $this, 'notification_filter_callback' ) );
@@ -471 +457 @@
 
     public function test_bp_core_process_spammer_status_bp_make_spam_user_filter() {
-        if ( is_multisite() && function_exists( 'wp_get_registered_image_subsizes' ) ) {
-            $this->setExpectedDeprecated( 'update_user_status' );
-        }
-
         add_filter( 'bp_make_spam_user', array( $this, 'notification_filter_callback' ) );
 
@@ -487 +469 @@
 
     public function test_bp_core_process_spammer_status_bp_make_ham_user_filter() {
-        if ( is_multisite() && function_exists( 'wp_get_registered_image_subsizes' ) ) {
-            $this->setExpectedDeprecated( 'update_user_status' );
-        }
-
         add_filter( 'bp_make_ham_user', array( $this, 'notification_filter_callback' ) );