Changeset 12426 for trunk/src/bp-groups/classes/class-bp-groups-template.php

Timestamp:

08/08/2019 08:11:51 PM (6 years ago)

Author:

boonebgorges

Message:

Cast func_get_args() to variable early in class methods.

Since PHP 7.0, calling func_get_args() returns the current value of
the parameter, which may have been modified since the beginning of the
method. By storing the original function arguments in a variable at the
beginning of the method, we ensure that the value operated on later in
the method accurately reflects what was originally passed.

In most cases addressed by this changeset, there was no real-world
possibility that the arguments could be changed; we make this change
mostly as a best practice, and to appease the PHP compatibility linter.

Fixes #8125.

File:

• trunk/src/bp-groups/classes/class-bp-groups-template.php (modified) (2 diffs)

trunk/src/bp-groups/classes/class-bp-groups-template.php

@@ -129 +129 @@
      */
     function __construct( $args = array() ){
+        $function_args = func_get_args();
 
         // Backward compatibility with old method of passing arguments.
-        if ( ! is_array( $args ) || func_num_args() > 1 ) {
+        if ( ! is_array( $args ) || count( $function_args ) > 1 ) {
             _deprecated_argument( __METHOD__, '1.7', sprintf( __( 'Arguments passed to %1$s should be in an associative array. See the inline documentation at %2$s for more details.', 'buddypress' ), __METHOD__, __FILE__ ) );
 
@@ -149 +150 @@
             );
 
-            $args = bp_core_parse_args_array( $old_args_keys, func_get_args() );
+            $args = bp_core_parse_args_array( $old_args_keys, $function_args );
         }