Changeset 12402 for branches/4.0/src/bp-messages/bp-messages-functions.php

Timestamp:

06/17/2019 05:41:01 PM (7 years ago)

Author:

imath

Message:

Make sure Messages exports only include the ones sent by the user

Using the $user->ID instead of the $recipients->ID to check for the sender ID is more reliable to make sure the generated zip Archive only contains messages sent by the requesting user.

Props gingerbooch, Venutius

See #8080 (branch 4.0)

File:

• branches/4.0/src/bp-messages/bp-messages-functions.php (modified) (1 diff)

branches/4.0/src/bp-messages/bp-messages-functions.php

@@ -685 +685 @@
         foreach ( $thread->messages as $message_index => $message ) {
             // Only include messages written by the user.
-            if ( $recipient->user_id !== $message->sender_id ) {
+            if ( $user->ID !== $message->sender_id ) {
                 continue;
             }