Changeset 12395 for trunk/src/bp-groups/bp-groups-functions.php

Timestamp:

05/11/2019 01:33:14 PM (6 years ago)

Author:

imath

Message:

Improve i18n of Groups activity updates action string

Dynamically generated activity action strings were introduced in BuddyPress 2.0 to ensure these strings are always up to date and multilingual-friendly (see #3856).

It appeared although the activity_update type enjoys this feature when activities are shared by users on their profiles, it was not the case for activity updates posted within Groups.

Thanks to this commit, BuddyPress is now taking it in charge by:

• Registering a new group activity action to reference a specific formatting callback function for activities posted within Groups.
• Making sure this new activity action type does not interfere with the one of regular activity updates in dropdown filters or into the Activity Administration screens.

BTW happy 4th WPTranslationDay to everyone :)

Fixes #8089

File:

• trunk/src/bp-groups/bp-groups-functions.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-functions.php

@@ -1267 +1267 @@
 }
 
-/** Group Activity Posting ****************************************************/
-
-/**
- * Post an Activity status update affiliated with a group.
- *
- * @since 1.2.0
- * @since 2.6.0 Added 'error_type' parameter to $args.
- *
- * @param array|string $args {
- *     Array of arguments.
- *     @type string $content  The content of the update.
- *     @type int    $user_id  Optional. ID of the user posting the update. Default:
- *                            ID of the logged-in user.
- *     @type int    $group_id Optional. ID of the group to be affiliated with the
- *                            update. Default: ID of the current group.
- * }
- * @return WP_Error|bool|int Returns the ID of the new activity item on success, or false on failure.
- */
-function groups_post_update( $args = '' ) {
-    if ( ! bp_is_active( 'activity' ) ) {
-        return false;
-    }
-
-    $bp = buddypress();
-
-    $r = bp_parse_args( $args, array(
-        'content'    => false,
-        'user_id'    => bp_loggedin_user_id(),
-        'group_id'   => 0,
-        'error_type' => 'bool'
-    ), 'groups_post_update' );
-    extract( $r, EXTR_SKIP );
-
-    if ( empty( $group_id ) && !empty( $bp->groups->current_group->id ) )
-        $group_id = $bp->groups->current_group->id;
-
-    if ( empty( $content ) || !strlen( trim( $content ) ) || empty( $user_id ) || empty( $group_id ) )
-        return false;
-
-    $bp->groups->current_group = groups_get_group( $group_id );
-
-    // Be sure the user is a member of the group before posting.
-    if ( !bp_current_user_can( 'bp_moderate' ) && !groups_is_user_member( $user_id, $group_id ) )
-        return false;
-
-    // Record this in activity streams.
-    $activity_action  = sprintf( esc_html__( '%1$s posted an update in the group %2$s', 'buddypress'), bp_core_get_userlink( $user_id ), '<a href="' . esc_url( bp_get_group_permalink( $bp->groups->current_group ) ) . '">' . esc_html( $bp->groups->current_group->name ) . '</a>' );
-    $activity_content = $content;
-
-    /**
-     * Filters the action for the new group activity update.
-     *
-     * @since 1.2.0
-     *
-     * @param string $activity_action The new group activity update.
-     */
-    $action = apply_filters( 'groups_activity_new_update_action',  $activity_action  );
-
-    /**
-     * Filters the content for the new group activity update.
-     *
-     * @since 1.2.0
-     *
-     * @param string $activity_content The content of the update.
-     */
-    $content_filtered = apply_filters( 'groups_activity_new_update_content', $activity_content );
-
-    $activity_id = groups_record_activity( array(
-        'user_id'    => $user_id,
-        'action'     => $action,
-        'content'    => $content_filtered,
-        'type'       => 'activity_update',
-        'item_id'    => $group_id,
-        'error_type' => $error_type
-    ) );
-
-    groups_update_groupmeta( $group_id, 'last_activity', bp_core_current_time() );
-
-    /**
-     * Fires after posting of an Activity status update affiliated with a group.
-     *
-     * @since 1.2.0
-     *
-     * @param string $content     The content of the update.
-     * @param int    $user_id     ID of the user posting the update.
-     * @param int    $group_id    ID of the group being posted to.
-     * @param bool   $activity_id Whether or not the activity recording succeeded.
-     */
-    do_action( 'bp_groups_posted_update', $content, $user_id, $group_id, $activity_id );
-
-    return $activity_id;
-}
-
 /** Group Invitations *********************************************************/