Changeset 12353 for trunk/src/bp-core/classes/class-bp-email.php

Timestamp:

03/06/2019 04:31:35 PM (8 years ago)

Author:

boonebgorges

Message:

Emails: Improve performance when setting Reply-To and From headers.

The new BP_Email_Participant framework allows the Reply-To and From email
headers to be set without requiring an empty and potentially expensive WP
user lookup.

Fixes #8003.

File:

• trunk/src/bp-core/classes/class-bp-email.php (modified) (5 diffs)

trunk/src/bp-core/classes/class-bp-email.php

@@ -66 +66 @@
          * @since 2.5.0
          *
-         * @var BP_Email_Recipient Sender details.
+         * @var BP_Email_Sender Sender details.
          */
         protected $from = null;
@@ -102 +102 @@
          * @since 2.5.0
          *
-         * @var BP_Email_Recipient "Reply to" details.
+         * @var BP_Email_Sender "Reply to" details.
          */
         protected $reply_to = null;
@@ -431 +431 @@
          * @param string $transform Optional. How to transform the return value.
          *                          Accepts 'raw' (default) or 'replace-tokens'.
-         * @return BP_Email_Recipient "From" recipient.
+         * @return BP_Email_Sender "From" recipient.
          */
         public function get_from( $transform = 'raw' ) {
@@ -739 +739 @@
          */
         public function set_from( $email_address, $name = '' ) {
-                $from = new BP_Email_Recipient( $email_address, $name );
+                $from = new BP_Email_Sender();
+
+                $from->set_address( $email_address );
+                $from->set_name( $name );
 
                 /**
@@ -811 +814 @@
          */
         public function set_reply_to( $email_address, $name = '' ) {
-                $reply_to = new BP_Email_Recipient( $email_address, $name );
+                $reply_to = new BP_Email_Sender();
+
+                $reply_to->set_address( $email_address );
+                $reply_to->set_name( $name );
 
                 /**