Changeset 12331 for trunk/src/bp-activity/classes/class-bp-activity-list-table.php

Timestamp:

02/02/2019 03:14:25 PM (6 years ago)

Author:

espellcaste

Message:

Added hooks to filter Activity and Groups list table get_sortable_columns

Adding custom hooks permitting the sortable columns of the Activity and Group list table to be filtered.

Props @modemlooper
Fixes #7533

File:

• trunk/src/bp-activity/classes/class-bp-activity-list-table.php (modified) (5 diffs)

trunk/src/bp-activity/classes/class-bp-activity-list-table.php

@@ -339 +339 @@
      * @return array Key/value pairs for the bulk actions dropdown.
      */
-    function get_bulk_actions() {
-        $actions = array();
-        $actions['bulk_spam']   = __( 'Mark as Spam', 'buddypress' );
-        $actions['bulk_ham']    = __( 'Not Spam', 'buddypress' );
-        $actions['bulk_delete'] = __( 'Delete Permanently', 'buddypress' );
+    public function get_bulk_actions() {
 
         /**
@@ -352 +348 @@
          * @param array $actions Default available actions for bulk operations.
          */
-        return apply_filters( 'bp_activity_list_table_get_bulk_actions', $actions );
+        return apply_filters( 'bp_activity_list_table_get_bulk_actions', array(
+            'bulk_spam'   => __( 'Mark as Spam', 'buddypress' ),
+            'bulk_ham'    => __( 'Not Spam', 'buddypress' ),
+            'bulk_delete' => __( 'Delete Permanently', 'buddypress' ),
+        ) );
     }
 
@@ -365 +365 @@
      */
     function get_columns() {
+
         /**
          * Filters the titles for the columns for the activity list table.
@@ -374 +375 @@
         return apply_filters( 'bp_activity_list_table_get_columns', array(
             'cb'       => '<input name type="checkbox" />',
-            'author'   => _x('Author', 'Admin SWA column header', 'buddypress' ),
+            'author'   => _x( 'Author', 'Admin SWA column header', 'buddypress' ),
             'comment'  => _x( 'Activity', 'Admin SWA column header', 'buddypress' ),
             'action'   => _x( 'Action', 'Admin SWA column header', 'buddypress' ),
@@ -384 +385 @@
      * Get the column names for sortable columns.
      *
-     * Currently, returns an empty array (no columns are sortable).
-     *
-     * @since 1.6.0
-     * @todo For this to work, BP_Activity_Activity::get() needs updating
-     *       to support ordering by specific fields.
+     * @since 1.6.0
      *
      * @return array The columns that can be sorted on the Activity screen.
      */
-    function get_sortable_columns() {
-        return array();
-
-        /*return array(
-            'author' => array( 'activity_author', false ),  // Intentionally not using "=>"
-        );*/
+    public function get_sortable_columns() {
+
+        /**
+         * Filters the column names for the sortable columns.
+         *
+         * @since 5.0.0
+         *
+         * @param array $value Array of column names.
+         */
+        return apply_filters( 'bp_activity_list_table_get_sortable_columns', array() );
     }