Changeset 12326 for trunk/src/bp-groups/classes/class-bp-groups-group.php

Timestamp:

01/15/2019 10:20:11 PM (8 years ago)

Author:

boonebgorges

Message:

Improve parent_id parsing in BP_Groups_Group.

The previous logic depended on behavior in wp_parse_id_list() that
will change in WP 5.1.

Fixes #8037.

File:

• trunk/src/bp-groups/classes/class-bp-groups-group.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -1203 +1203 @@
 
                 if ( ! is_null( $r['parent_id'] ) ) {
-                        // Note that `wp_parse_id_list()` converts `false` to 0.
-                        $parent_id        = implode( ',', wp_parse_id_list( $r['parent_id'] ) );
+                        // For legacy reasons, `false` means groups with no parent.
+                        if ( false === $r['parent_id'] ) {
+                                $parent_id = 0;
+                        } else {
+                                $parent_id = implode( ',', wp_parse_id_list( $r['parent_id'] ) );
+                        }
+
                         $where_conditions['parent_id'] = "g.parent_id IN ({$parent_id})";
                 }