Changeset 12323

Timestamp:

01/11/2019 02:14:28 AM (6 years ago)

Author:

boonebgorges

Message:

Avoid PHP notices when saving widget link_title.

Props dcavins.
See #8036.

Location:

trunk/src

Files:

• bp-blogs/classes/class-bp-blogs-recent-posts-widget.php (modified) (1 diff)
• bp-friends/classes/class-bp-core-friends-widget.php (modified) (1 diff)
• bp-groups/classes/class-bp-groups-widget.php (modified) (1 diff)
• bp-members/classes/class-bp-core-members-widget.php (modified) (1 diff)

trunk/src/bp-blogs/classes/class-bp-blogs-recent-posts-widget.php

@@ -132 +132 @@
         $instance['title']      = strip_tags( $new_instance['title'] );
         $instance['max_posts']  = strip_tags( $new_instance['max_posts'] );
-        $instance['link_title'] = (bool) $new_instance['link_title'];
+        $instance['link_title'] = ! empty( $new_instance['link_title'] );
 
         return $instance;

trunk/src/bp-friends/classes/class-bp-core-friends-widget.php

@@ -162 +162 @@
         $instance['max_friends']    = absint( $new_instance['max_friends'] );
         $instance['friend_default'] = sanitize_text_field( $new_instance['friend_default'] );
-        $instance['link_title']     = (bool) $new_instance['link_title'];
+        $instance['link_title']     = ! empty( $new_instance['link_title'] );
 
         return $instance;

trunk/src/bp-groups/classes/class-bp-groups-widget.php

@@ -187 +187 @@
         $instance['max_groups']    = strip_tags( $new_instance['max_groups'] );
         $instance['group_default'] = strip_tags( $new_instance['group_default'] );
-        $instance['link_title']    = (bool) $new_instance['link_title'];
+        $instance['link_title']    = ! empty( $new_instance['link_title'] );
 
         return $instance;

trunk/src/bp-members/classes/class-bp-core-members-widget.php

@@ -181 +181 @@
         $instance['max_members']    = strip_tags( $new_instance['max_members'] );
         $instance['member_default'] = strip_tags( $new_instance['member_default'] );
-        $instance['link_title']     = (bool) $new_instance['link_title'];
+        $instance['link_title']     = ! empty( $new_instance['link_title'] );
 
         return $instance;