Changeset 12307

Timestamp:

12/03/2018 09:14:24 PM (8 years ago)

Author:

boonebgorges

Message:

Don't pass non-existent total_count value to notification export filter.

total_count is available only in other contexts where this filter exists.
Instead, we pass a null value.

Props Venutius.
Fixes #8015.

File:

• trunk/src/bp-notifications/bp-notifications-functions.php (modified) (1 diff)

trunk/src/bp-notifications/bp-notifications-functions.php

@@ -842 +842 @@
                         $content = call_user_func( buddypress()->{$component_name}->notification_callback, $notification->component_action, $notification->item_id, $notification->secondary_item_id, 1, 'string', $notification->id );
                 } else {
-                        // The array to reference with apply_filters_ref_array().
+                        /*
+                         * Compile an array of data to send to filter.
+                         *
+                         * Note that a null value is passed in the slot filled by `total_count` in
+                         * other filter contexts. We don't have enough info here to pass a `total_count`.
+                         */
                         $ref_array = array(
                                 $notification->component_action,
                                 $notification->item_id,
                                 $notification->secondary_item_id,
-                                $notification->total_count,
+                                null,
                                 'string',
                                 $notification->component_action,