Changeset 12290

Timestamp:

11/15/2018 08:49:09 PM (7 years ago)

Author:

boonebgorges

Message:

Nouveau: Fix back compat for plugins adding markup at 'groups_custom_group_fields_editable'.

Props r-a-y, imath.
Fixes #7837.

Location:

trunk/src/bp-templates/bp-nouveau

Files:

• buddypress/groups/single/admin/edit-details.php (modified) (2 diffs)
• includes/groups/template-tags.php (modified) (2 diffs)

trunk/src/bp-templates/bp-nouveau/buddypress/groups/single/admin/edit-details.php

@@ -5 +5 @@
  * @since 3.0.0
  * @version 3.1.0
+ * @version 4.0.0 Removed 'Notify group members' checkbox in favor of hooked callback.
  */
 ?>
@@ -27 +28 @@
 <label for="group-desc"><?php esc_html_e( 'Group Description (required)', 'buddypress' ); ?></label>
 <textarea name="group-desc" id="group-desc" aria-required="true"><?php bp_is_group_create() ? bp_new_group_description() : bp_group_description_editable(); ?></textarea>
-
-<?php if ( ! bp_is_group_create() ) : ?>
-    <p class="bp-controls-wrap">
-        <label for="group-notify-members" class="bp-label-text">
-            <input type="checkbox" name="group-notify-members" id="group-notify-members" value="1" /> <?php esc_html_e( 'Notify group members of these changes via email', 'buddypress' ); ?>
-        </label>
-    </p>
-<?php endif; ?>

trunk/src/bp-templates/bp-nouveau/includes/groups/template-tags.php

@@ -335 +335 @@
 
         if ( ! empty( $core_screen['hook'] ) ) {
+
+            // Group's "Manage > Details" page.
+            if ( 'group_details_admin' === $core_screen['hook'] ) {
+                /**
+                 * Fires after the group description admin details.
+                 *
+                 * @since 1.0.0
+                 */
+                do_action( 'groups_custom_group_fields_editable' );
+            }
+
             /**
              * Fires before the display of group delete admin.
@@ -1389 +1400 @@
     }
 }
+
+/**
+ * Adds the "Notify group members of these changes" checkbox to the Manage > Details panel.
+ *
+ * See #7837 for background on why this technique is required.
+ *
+ * @since 4.0.0
+ */
+function bp_nouveau_add_notify_group_members_checkbox() {
+    printf( '<p class="bp-controls-wrap">
+        <label for="group-notify-members" class="bp-label-text">
+            <input type="checkbox" name="group-notify-members" id="group-notify-members" value="1" /> %s
+        </label>
+    </p>', esc_html__( 'Notify group members of these changes via email', 'buddypress' ) );
+}
+add_action( 'groups_custom_group_fields_editable', 'bp_nouveau_add_notify_group_members_checkbox', 20 );