Changeset 12288 for trunk/src/bp-core/classes/class-bp-component.php

Timestamp:

11/15/2018 08:14:01 PM (6 years ago)

Author:

boonebgorges

Message:

Nav: Dynamically load component screen file when changing nav default.

BP 3.0.0 moved most screen controllers into files that are loaded only when
viewing the component. This introduced a regression into
bp_core_new_nav_default(), since the screen_function would not be available
(ie ! is_callable()) at the time that the nav item is modified.

We resolve this by loading the component's screen functions in
bp_core_new_nav_default() when we detect that they're not present. To work
around cases where component slugs don't match the official component ID,
which corresponds to the file path, we introduce a new 'component_id' parameter
to be used when registering a new nav item.

Props imath, r-a-y.
Fixes #7935.

File:

• trunk/src/bp-core/classes/class-bp-component.php (modified) (1 diff)

trunk/src/bp-core/classes/class-bp-component.php

@@ -499 +499 @@
         // No sub nav items without a main nav item.
         if ( !empty( $main_nav ) ) {
+            // Always set the component ID.
+            $main_nav['component_id'] = $this->id;
+
             bp_core_new_nav_item( $main_nav, 'members' );