Changeset 12257

Timestamp:

10/20/2018 02:53:54 PM (8 years ago)

Author:

boonebgorges

Message:

bp-legacy: Disable cookie-based filter "preferences" for activity directory when logged out.

Extends the changes in [12255] to the activity directory, which uses
a different technique for directory filter template requests.

See #7856.

File:

• trunk/src/bp-templates/bp-legacy/js/buddypress.js (modified) (2 diffs)

trunk/src/bp-templates/bp-legacy/js/buddypress.js

@@ -1903 +1903 @@
 /* Activity Loop Requesting */
 function bp_activity_request(scope, filter) {
-        /* Save the type and filter to a session cookie */
-        if ( null !== scope ) {
-                jq.cookie( 'bp-activity-scope', scope, {
-                        path: '/',
-                        secure: ( 'https:' === window.location.protocol )
-                } );
-        }
-        if ( null !== filter ) {
-                jq.cookie( 'bp-activity-filter', filter, {
-                        path: '/',
-                        secure: ( 'https:' === window.location.protocol )
-                } );
-        }
+        /* Save the type and filter */
+        bp_set_directory_preference( 'activity', 'scope', scope );
+        bp_set_directory_preference( 'activity', 'filter', filter );
 
         /* Remove selected and loading classes from tabs */
@@ -1933 +1923 @@
         }
 
+        // Get directory preferences (called "cookie" for legacy reasons).
+        var cookies = {
+                'bp-activity-filter': bp_get_directory_preference( 'activity', 'filter' ),
+                'bp-activity-scope': bp_get_directory_preference( 'activity', 'scope' )
+        };
+
+        var cookie = encodeURIComponent( jq.param( cookies ) );
+
         bp_ajax_request = jq.post( ajaxurl, {
                 action: 'activity_widget_filter',
-                'cookie': bp_get_cookies(),
+                'cookie': cookie,
                 '_wpnonce_activity_filter': jq('#_wpnonce_activity_filter').val(),
                 'scope': scope,