Changeset 12241

Timestamp:

10/04/2018 06:16:38 PM (6 years ago)

Author:

boonebgorges

Message:

Groups: Improve Dashboard add-user interface for networks with many users.

When wp_is_large_network( 'users' ), the JS-driven autocomplete functionality
for the new member field should degrade gracefully.

Fixes #7980.

Location:

trunk/src/bp-groups

Files:

• admin/js/admin.js (modified) (1 diff)
• bp-groups-admin.php (modified) (2 diffs)

trunk/src/bp-groups/admin/js/admin.js

@@ -22 +22 @@
 
         /* Replace noscript placeholder */
-        $( '#bp-groups-new-members' ).prop( 'placeholder', BP_Group_Admin.add_member_placeholder );
+        $( '#bp-groups-new-members.bp-suggest-user' ).prop( 'placeholder', BP_Group_Admin.add_member_placeholder );
 
         /* Remove a member on 'x' click */

trunk/src/bp-groups/bp-groups-admin.php

@@ -862 +862 @@
  */
 function bp_groups_admin_edit_metabox_add_new_members( $item ) {
+    if ( wp_is_large_network( 'users' ) ) {
+        $class  = '';
+        $notice = __( 'Enter a comma-separated list of user logins.', 'buddypress' );
+    } else {
+        $class  = 'bp-suggest-user';
+        $notice = '';
+    }
+
     ?>
 
@@ -868 +876 @@
         _e( 'Add new members', 'buddypress' );
     ?></label>
-    <input name="bp-groups-new-members" type="text" id="bp-groups-new-members" class="bp-suggest-user" placeholder="<?php esc_attr_e( 'Enter a comma-separated list of user logins.', 'buddypress' ) ?>" />
+    <input name="bp-groups-new-members" type="text" id="bp-groups-new-members" class="<?php echo esc_attr( $class ); ?>" placeholder="" />
+    <?php if ( $notice ) : ?>
+        <p class="description"><?php echo esc_html( $notice ); ?></p>
+    <?php endif; ?>
     <ul id="bp-groups-new-members-list"></ul>
     <?php