Changeset 12126 for trunk/src/bp-groups/bp-groups-functions.php

Timestamp:

05/25/2018 11:12:06 PM (7 years ago)

Author:

r-a-y

Message:

Groups: Wrap groups_record_activity() calls with bp_is_active( 'activity' )

In r11924, the bp-groups-activity.php file is loaded only if the Activity
component is enabled.

However, the groups_record_activity() function is located in this file.
Because this function now relies on the Activity component, if the Activity
component is disabled, a fatal error can occur during certain group
actions. This commit addresses the problem by checking for the Activity
component before calling on the function.

Anti-props r-a-y.

See #7870 (trunk).

File:

• trunk/src/bp-groups/bp-groups-functions.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-functions.php

@@ -586 +586 @@
 
     // Record this in activity streams.
-    groups_record_activity( array(
-        'type'    => 'joined_group',
-        'item_id' => $group_id,
-        'user_id' => $user_id,
-    ) );
+    if ( bp_is_active( 'activity' ) ) {
+        groups_record_activity( array(
+            'type'    => 'joined_group',
+            'item_id' => $group_id,
+            'user_id' => $user_id,
+        ) );
+    }
 
     /**