Changeset 12106

Timestamp:

05/21/2018 01:03:05 AM (7 years ago)

Author:

djpaul

Message:

Templates, Nouveau: use strict type checking for in_array() calls.

Location:

trunk/src/bp-templates/bp-nouveau/includes

Files:

• activity/functions.php (modified) (1 diff)
• activity/template-tags.php (modified) (1 diff)
• activity/widgets.php (modified) (1 diff)
• groups/functions.php (modified) (1 diff)
• messages/functions.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/includes/activity/functions.php

@@ -418 +418 @@
 
                 // The current activity is one of the new mentions
-                if ( is_array( $new_mentions ) && in_array( bp_get_activity_id(), $new_mentions ) ) {
+                if ( is_array( $new_mentions ) && in_array( bp_get_activity_id(), $new_mentions, true ) ) {
                     $my_classes[] = 'bp-my-mentions';
                 }

trunk/src/bp-templates/bp-nouveau/includes/activity/template-tags.php

@@ -563 +563 @@
         }
 
-        if ( isset( $return['activity_spam'] ) && ! in_array( $activity_type, BP_Akismet::get_activity_types() ) ) {
+        if ( isset( $return['activity_spam'] ) && ! in_array( $activity_type, BP_Akismet::get_activity_types(), true ) ) {
             unset( $return['activity_spam'] );
         }

trunk/src/bp-templates/bp-nouveau/includes/activity/widgets.php

@@ -193 +193 @@
             <select class="widefat" multiple="multiple" id="<?php echo $this->get_field_id( 'type' ); ?>" name="<?php echo $this->get_field_name( 'type' ); ?>[]">
                 <?php foreach ( bp_nouveau_get_activity_filters() as $key => $name ) : ?>
-                    <option value="<?php echo esc_attr( $key ); ?>" <?php selected( in_array( $key, $type ) ); ?>><?php echo esc_html( $name ); ?></option>
+                    <option value="<?php echo esc_attr( $key ); ?>" <?php selected( in_array( $key, $type, true ) ); ?>><?php echo esc_html( $name ); ?></option>
                 <?php endforeach; ?>
             </select>

trunk/src/bp-templates/bp-nouveau/includes/groups/functions.php

@@ -225 +225 @@
             $response['can_edit'] = true;
         } else {
-            $response['can_edit'] = in_array( bp_loggedin_user_id(), $inviter_ids );
+            $response['can_edit'] = in_array( bp_loggedin_user_id(), $inviter_ids, true );
         }
     }

trunk/src/bp-templates/bp-nouveau/includes/messages/functions.php

@@ -296 +296 @@
     }
 
-    if ( $notice->id && is_array( $closed_notices ) && ! in_array( $notice->id, $closed_notices ) ) {
+    if ( $notice->id && is_array( $closed_notices ) && ! in_array( $notice->id, $closed_notices, true ) ) {
         // Inject the notice into the template_message if no other message has priority.
         $bp = buddypress();