Changeset 12067 for trunk/src/bp-activity/bp-activity-filters.php

Timestamp:

05/06/2018 10:47:08 AM (7 years ago)

Author:

imath

Message:

BP Nouveau: restrict the allowed HTML tags for Messages.

BP Nouveau is using the WP Editor to improve the user experience of the Messages component when people are writing a new message or replying to a thread. So far allowed HTML tags for the messages content *when BP Nouveau is the active template pack* were the same than WordPress Posts. When BP Nouveau is not the active template pack, the allowed tags are those of the WordPress global .

This commit is introducing a new function that is used to filter the allowed HTML tags for activity content and message content. It extends the with new tags (img, span, ul, ol & li) and leaves specific functions to the 2 components to include filters so that it is possible to restrict/extend allowed HTML tags for both content types or one of them. It also restricts the WP Editor available buttons when used into the BP Nouveau Messages UI so that they are consistent with the allowed HTML tags.

Props DJPaul

Fixes #7795

File:

• trunk/src/bp-activity/bp-activity-filters.php (modified) (2 diffs)

trunk/src/bp-activity/bp-activity-filters.php

@@ -203 +203 @@
  */
 function bp_activity_filter_kses( $content ) {
-    global $allowedtags;
-
-    $activity_allowedtags = $allowedtags;
-    $activity_allowedtags['a']['aria-label']      = array();
-    $activity_allowedtags['a']['class']           = array();
-    $activity_allowedtags['a']['data-bp-tooltip'] = array();
-    $activity_allowedtags['a']['id']              = array();
-    $activity_allowedtags['a']['rel']             = array();
-    $activity_allowedtags['a']['title']           = array();
-
-    $activity_allowedtags['b']    = array();
-    $activity_allowedtags['code'] = array();
-    $activity_allowedtags['i']    = array();
-
-    $activity_allowedtags['img']           = array();
-    $activity_allowedtags['img']['src']    = array();
-    $activity_allowedtags['img']['alt']    = array();
-    $activity_allowedtags['img']['width']  = array();
-    $activity_allowedtags['img']['height'] = array();
-    $activity_allowedtags['img']['class']  = array();
-    $activity_allowedtags['img']['id']     = array();
-
-    $activity_allowedtags['span']                   = array();
-    $activity_allowedtags['span']['class']          = array();
-    $activity_allowedtags['span']['data-livestamp'] = array();
-
-    $activity_allowedtags['ul'] = array();
-    $activity_allowedtags['ol'] = array();
-    $activity_allowedtags['li'] = array();
-
     /**
      * Filters the allowed HTML tags for BuddyPress Activity content.
@@ -240 +210 @@
      * @param array $value Array of allowed HTML tags and attributes.
      */
-    $activity_allowedtags = apply_filters( 'bp_activity_allowed_tags', $activity_allowedtags );
+    $activity_allowedtags = apply_filters( 'bp_activity_allowed_tags', bp_get_allowedtags() );
     return wp_kses( $content, $activity_allowedtags );
 }