Changeset 12054

Timestamp:

05/03/2018 08:41:41 PM (6 years ago)

Author:

mercime

Message:

BP Nouveau: Add aria-hidden attribute to hide icons from assistive technologies.

Fixes #7808.

Location:

trunk/src/bp-templates/bp-nouveau

Files:

• buddypress/common/js-templates/invites/index.php (modified) (2 diffs)
• includes/messages/functions.php (modified) (1 diff)
• includes/notifications/template-tags.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php

@@ -67 +67 @@
         <# if ( undefined === data.is_sent || ( false === data.is_sent && true === data.can_edit ) ) { #>
             <button type="button" class="button invite-button group-add-remove-invite-button bp-tooltip bp-icons" data-bp-tooltip="<?php esc_attr_e( 'Invite / Uninvite', 'buddypress' ); ?>">
-                <span class="icons"></span>
+                <span class="icons" aria-hidden="true"></span>
                 <span class="bp-screen-reader-text"><?php esc_html_e( 'Invite/Uninvite', 'buddypress' ); ?></span>
             </button>
@@ -74 +74 @@
         <# if ( undefined !== data.can_edit && true === data.can_edit ) { #>
             <button type="button" class="button invite-button group-remove-invite-button bp-tooltip bp-icons" data-bp-tooltip="<?php esc_attr_e( 'Remove', 'buddypress' ); ?>">
-                <span class=" icons"></span>
+                <span class=" icons" aria-hidden="true"></span>
                 <span class="bp-screen-reader-text"><?php esc_html_e( 'Remove', 'buddypress' ); ?></span>
             </button>

trunk/src/bp-templates/bp-nouveau/includes/messages/functions.php

@@ -99 +99 @@
             'send' => wp_create_nonce( 'messages_send_message' ),
         ),
-        'loading' => '<div class="bp-feedback info"><span class="bp-icon"></span><p>' . __( 'Loading messages. Please wait.', 'buddypress' ) . '</p></div>',
+        'loading' => '<div class="bp-feedback info"><span class="bp-icon" aria-hidden="true"></span><p>' . __( 'Loading messages. Please wait.', 'buddypress' ) . '</p></div>',
         'bulk_actions' => bp_nouveau_messages_get_bulk_actions(),
     );

trunk/src/bp-templates/bp-nouveau/includes/notifications/template-tags.php

@@ -82 +82 @@
 
     <span class="notifications-order-actions">
-        <a href="<?php echo esc_url( $desc ); ?>" class="bp-tooltip" data-bp-tooltip="<?php esc_attr_e( 'Newest First', 'buddypress' ); ?>" aria-label="<?php esc_attr_e( 'Newest First', 'buddypress' ); ?>" data-bp-notifications-order="DESC"><span class="dashicons dashicons-arrow-down"></span></a>
+        <a href="<?php echo esc_url( $desc ); ?>" class="bp-tooltip" data-bp-tooltip="<?php esc_attr_e( 'Newest First', 'buddypress' ); ?>" aria-label="<?php esc_attr_e( 'Newest First', 'buddypress' ); ?>" data-bp-notifications-order="DESC"><span class="dashicons dashicons-arrow-down" aria-hidden="true"></span></a>
         <a href="<?php echo esc_url( $asc ); ?>" class="bp-tooltip" data-bp-tooltip="<?php esc_attr_e( 'Older First', 'buddypress' ); ?>" aria-label="<?php esc_attr_e( 'Older First', 'buddypress' ); ?>" data-bp-notifications-order="ASC"><span class="dashicons dashicons-arrow-up" aria-hidden="true"></span></a>
     </span>