Changeset 12034

Timestamp:

05/01/2018 09:30:06 PM (6 years ago)

Author:

imath

Message:

BP Nouveau: Activity directory, remove misleading 0 count from tabs.

Into the Activity directory the count spans added to the scope tabs are there to inform about newest activities (HeartBeat) for each scope. Starting the UI with a count set to 0 can be misleading because we could believe this count is about the total number of activities for each scope.

Fixes #7788

File:

• trunk/src/bp-templates/bp-nouveau/js/buddypress-activity.js (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/js/buddypress-activity.js

@@ -403 +403 @@
             // Reset the newest activities now they're displayed
             this.heartbeat_data.newest = '';
-            $( bp.Nouveau.objectNavParent + ' [data-bp-scope="all"]' ).find( 'a span' ).html( '' );
+            $.each( $( bp.Nouveau.objectNavParent + ' [data-bp-scope]' ).find( 'a span' ), function( s, count ) {
+                if ( 0 === parseInt( $( count ).html(), 10 ) ) {
+                    $( count ).html( '' );
+                }
+            } );
 
             // Activities are now loaded, clear the highlighted activities for the scope