Changeset 11938

Timestamp:

04/02/2018 10:40:59 PM (7 years ago)

Author:

djpaul

Message:

Move (retired) Legacy Forum backwards compatibility functions into deprecated/3.0 file.

See #5351

Location:

trunk/src

Files:

• bp-core/bp-core-options.php (modified) (1 diff)
• bp-core/bp-core-template.php (modified) (2 diffs)
• bp-core/deprecated/3.0.php (added)
• bp-groups/bp-groups-template.php (modified) (2 diffs)
• class-buddypress.php (modified) (1 diff)

trunk/src/bp-core/bp-core-options.php

@@ -690 +690 @@
 
 /**
- * Check whether bbPress plugin-powered Group Forums are enabled.
- *
- * @since 1.6.0
- * @since 3.0.0 $default argument's default value changed from true to false.
- * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
- *
- * @param bool $default Optional. Fallback value if not found in the database.
- *                      Default: false.
- * @return bool True if group forums are active, otherwise false.
- */
-function bp_is_group_forums_active( $default = false ) {
-    $is_active = function_exists( 'bbp_is_group_forums_active' ) ? bbp_is_group_forums_active( $default ) : $default;
-
-    /**
-     * Filters whether or not bbPress plugin-powered Group Forums are enabled.
-     *
-     * @since 1.6.0
-     * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
-     *
-     * @param bool $value Whether or not bbPress plugin-powered Group Forums are enabled.
-     */
-    return (bool) apply_filters( 'bp_is_group_forums_active', $is_active );
-}
-
-/**
- * Check whether Akismet is enabled.
- *
- * @since 1.6.0
- *
- * @param bool $default Optional. Fallback value if not found in the database.
- *                      Default: true.
- * @return bool True if Akismet is enabled, otherwise false.
- */
-function bp_is_akismet_active( $default = true ) {
-
-    /**
-     * Filters whether or not Akismet is enabled.
-     *
-     * @since 1.6.0
-     *
-     * @param bool $value Whether or not Akismet is enabled.
-     */
-    return (bool) apply_filters( 'bp_is_akismet_active', (bool) bp_get_option( '_bp_enable_akismet', $default ) );
-}
-
-/**
  * Check whether Activity Heartbeat refresh is enabled.
  *

trunk/src/bp-core/bp-core-template.php

@@ -2475 +2475 @@
 
 /**
- * Is this a user's forums page?
- *
- * Eg http://example.com/members/joe/forums/ (or a subpage thereof).
- *
- * @since 1.5.0
- * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
- *
- * @return false
- */
-function bp_is_user_forums() {
-    return false;
-}
-
-/**
  * Is the current page part of a user's Groups page?
  *
@@ -2720 +2706 @@
 function bp_is_group_admin_page() {
     return (bool) ( bp_is_single_item() && bp_is_groups_component() && bp_is_current_action( 'admin' ) );
-}
-
-/**
- * Is the current page a group's (legacy bbPress) forum page?
- *
- * @since 1.1.0
- * @since 3.0.0 Always returns false.
- * @deprecated 3.0.0 No longer used in core, but supported for custom theme templates.
- *
- * @return bool
- */
-function bp_is_group_forum() {
-    return false;
 }
 

trunk/src/bp-groups/bp-groups-template.php

@@ -470 +470 @@
  * Is the group accessible to the currently logged-in user?
  * Despite the name of the function, it has historically checked
- * whether a user has access to a group. 
- * In BP 2.9, a property was added to the BP_Groups_Group class, 
+ * whether a user has access to a group.
+ * In BP 2.9, a property was added to the BP_Groups_Group class,
  * `is_visible`, that describes whether a user can know the group exists.
- * If you wish to check that property, use the check: 
+ * If you wish to check that property, use the check:
  * bp_current_user_can( 'groups_see_group' ).
  *
@@ -3220 +3220 @@
     return true;
 }
-
-/**
- * Output a 'New Topic' button for a group.
- *
- * @since 1.2.7
- * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
- *
- * @param BP_Groups_Group|bool $group The BP Groups_Group object if passed, boolean false if not passed.
- */
-function bp_group_new_topic_button( $group = false ) {
-}
-
-    /**
-     * Return a 'New Topic' button for a group.
-     *
-     * @since 1.2.7
-     * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
-     *
-     * @param BP_Groups_Group|bool $group The BP Groups_Group object if passed, boolean false if not passed.
-     *
-     * @return false
-     */
-    function bp_get_group_new_topic_button( $group = false ) {
-        return false;
-    }
 
 /**

trunk/src/class-buddypress.php

@@ -490 +490 @@
             require( $this->plugin_dir . 'bp-core/deprecated/2.8.php' );
             require( $this->plugin_dir . 'bp-core/deprecated/2.9.php' );
+            require( $this->plugin_dir . 'bp-core/deprecated/3.0.php' );
         }
     }