Skip to:
Content

BuddyPress.org

Changeset 11916


Ignore:
Timestamp:
03/31/2018 01:44:18 PM (4 years ago)
Author:
hnla
Message:

Nouveau: Re-factor Compose pencil icon

Commit changes the compose link to a text one removing the pencil icon.

As an icon it might not have been clear to the purpose of the link, as text it's clearer and is also easier to handle styling/layout within the li element structure.

Props mercime

Fixes #7715

Location:
trunk/src/bp-templates/bp-nouveau
Files:
6 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-templates/bp-nouveau/common-styles/_bp_buttons.scss

    r11813 r11916  
    3434            text-decoration: none;
    3535            width: auto;
    36         }
    37 
    38         // Reduce padding for messages screens compose button
    39         // to prevent border clipping in tab visual layout
    40         li.last a#compose {
    41             padding: 2px 8px;
    4236        }
    4337
  • trunk/src/bp-templates/bp-nouveau/common-styles/_bp_navigation.scss

    r11813 r11916  
    517517                margin-top: 2px;
    518518
    519                 li#compose-personal-li {
    520                     margin-top: 6px;
    521                 }
    522 
    523519                // For tabbed nav we remove any default button nav styles.
    524520                ul {
  • trunk/src/bp-templates/bp-nouveau/css/buddypress-rtl.css

    r11915 r11916  
    602602        margin-top: 2px;
    603603    }
    604     .buddypress-wrap .item-body .bp-navs.tabbed-links li#compose-personal-li {
    605         margin-top: 6px;
    606     }
    607604    .buddypress-wrap .item-body .bp-navs.tabbed-links ul li a {
    608605        border-left: 0;
     
    637634.buddypress-wrap .subnav-filters {
    638635    background: none;
    639     overflow: hidden;
    640636    list-style: none;
    641     margin: 15px 0;
     637    margin: 15px 0 0;
    642638    padding: 0;
    643639}
     
    656652}
    657653
    658 @media screen and (max-width: 46.8em) {
     654.buddypress-wrap .subnav-filters.bp-messages-filters .messages-search {
     655    margin-bottom: 1em;
     656}
     657
     658@media screen and (min-width: 46.8em) {
    659659    .buddypress-wrap .subnav-filters.bp-messages-filters .messages-search {
    660         clear: both;
     660        margin-bottom: 0;
    661661    }
    662662}
     
    703703.buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions-wrap {
    704704    border: 1px solid #eee;
    705     float: right;
     705}
     706
     707.buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions-wrap.bp-show {
     708    display: inline-block;
     709}
     710
     711.buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions-wrap.bp-hide {
     712    display: none;
    706713}
    707714
     
    710717}
    711718
    712 .buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions,
     719.buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions {
     720    float: right;
     721}
     722
    713723.buddypress-wrap .subnav-filters .user-messages-bulk-actions label {
    714     float: right;
    715 }
    716 
    717 .buddypress-wrap .subnav-filters .user-messages-bulk-actions label {
     724    display: inline-block;
     725    font-weight: 300;
     726    margin-left: 25px;
    718727    padding: 5px 0;
    719     text-align: center;
    720     width: 30px;
    721728}
    722729
     
    27642771.message-action-star:before,
    27652772.message-action-unstar:before,
    2766 .bp-navs ul li#compose-personal-li a#compose:before,
    27672773.message-action-view:before,
    27682774.message-action-delete:before {
     
    27712777}
    27722778
    2773 .bp-navs ul li#compose-personal-li a#compose:before {
    2774     font-size: 22px;
    2775 }
    2776 
    27772779.message-action-star:before {
    27782780    color: #aaa;
     
    27992801.preview-content .actions a {
    28002802    text-decoration: none;
    2801 }
    2802 
    2803 li#compose-personal-li.last {
    2804     margin-top: 0;
    2805 }
    2806 
    2807 li#compose-personal-li a#compose {
    2808     display: inline-block;
    2809     padding: 1px 6px;
    2810 }
    2811 
    2812 li#compose-personal-li a#compose:before {
    2813     content: "\f464";
    2814 }
    2815 
    2816 li#compose-personal-li a#compose:focus,
    2817 li#compose-personal-li a#compose:hover {
    2818     background: #eee;
    2819     color: #e8861e;
    28202803}
    28212804
     
    28862869    -o-flex: 1 2 5%;
    28872870    flex: 1 2 5%;
    2888 }
    2889 
    2890 #message-threads li .thread-cb label {
    2891     float: right;
    2892     margin-right: 5px;
    2893     text-align: center;
    2894     width: 5%;
    28952871}
    28962872
     
    38643840}
    38653841
    3866 .buddypress .buddypress-wrap li.last a#compose {
    3867     padding: 2px 8px;
    3868 }
    3869 
    38703842.buddypress .buddypress-wrap .button-small[type="button"] {
    38713843    padding: 0 8px 1px;
  • trunk/src/bp-templates/bp-nouveau/css/buddypress.css

    r11915 r11916  
    602602        margin-top: 2px;
    603603    }
    604     .buddypress-wrap .item-body .bp-navs.tabbed-links li#compose-personal-li {
    605         margin-top: 6px;
    606     }
    607604    .buddypress-wrap .item-body .bp-navs.tabbed-links ul li a {
    608605        border-right: 0;
     
    637634.buddypress-wrap .subnav-filters {
    638635    background: none;
    639     overflow: hidden;
    640636    list-style: none;
    641     margin: 15px 0;
     637    margin: 15px 0 0;
    642638    padding: 0;
    643639}
     
    656652}
    657653
    658 @media screen and (max-width: 46.8em) {
     654.buddypress-wrap .subnav-filters.bp-messages-filters .messages-search {
     655    margin-bottom: 1em;
     656}
     657
     658@media screen and (min-width: 46.8em) {
    659659    .buddypress-wrap .subnav-filters.bp-messages-filters .messages-search {
    660         clear: both;
     660        margin-bottom: 0;
    661661    }
    662662}
     
    703703.buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions-wrap {
    704704    border: 1px solid #eee;
    705     float: left;
     705}
     706
     707.buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions-wrap.bp-show {
     708    display: inline-block;
     709}
     710
     711.buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions-wrap.bp-hide {
     712    display: none;
    706713}
    707714
     
    710717}
    711718
    712 .buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions,
     719.buddypress-wrap .subnav-filters .user-messages-bulk-actions .bulk-actions {
     720    float: left;
     721}
     722
    713723.buddypress-wrap .subnav-filters .user-messages-bulk-actions label {
    714     float: left;
    715 }
    716 
    717 .buddypress-wrap .subnav-filters .user-messages-bulk-actions label {
     724    display: inline-block;
     725    font-weight: 300;
     726    margin-right: 25px;
    718727    padding: 5px 0;
    719     text-align: center;
    720     width: 30px;
    721728}
    722729
     
    27642771.message-action-star:before,
    27652772.message-action-unstar:before,
    2766 .bp-navs ul li#compose-personal-li a#compose:before,
    27672773.message-action-view:before,
    27682774.message-action-delete:before {
     
    27712777}
    27722778
    2773 .bp-navs ul li#compose-personal-li a#compose:before {
    2774     font-size: 22px;
    2775 }
    2776 
    27772779.message-action-star:before {
    27782780    color: #aaa;
     
    27992801.preview-content .actions a {
    28002802    text-decoration: none;
    2801 }
    2802 
    2803 li#compose-personal-li.last {
    2804     margin-top: 0;
    2805 }
    2806 
    2807 li#compose-personal-li a#compose {
    2808     display: inline-block;
    2809     padding: 1px 6px;
    2810 }
    2811 
    2812 li#compose-personal-li a#compose:before {
    2813     content: "\f464";
    2814 }
    2815 
    2816 li#compose-personal-li a#compose:focus,
    2817 li#compose-personal-li a#compose:hover {
    2818     background: #eee;
    2819     color: #e8861e;
    28202803}
    28212804
     
    28862869    -o-flex: 1 2 5%;
    28872870    flex: 1 2 5%;
    2888 }
    2889 
    2890 #message-threads li .thread-cb label {
    2891     float: left;
    2892     margin-left: 5px;
    2893     text-align: center;
    2894     width: 5%;
    28952871}
    28962872
     
    38643840}
    38653841
    3866 .buddypress .buddypress-wrap li.last a#compose {
    3867     padding: 2px 8px;
    3868 }
    3869 
    38703842.buddypress .buddypress-wrap .button-small[type="button"] {
    38713843    padding: 0 8px 1px;
  • trunk/src/bp-templates/bp-nouveau/js/buddypress-messages.js

    r11906 r11916  
    4545            // First adapt the compose nav
    4646            $( '#compose-personal-li' ).addClass( 'last' );
    47             $( '#compose-personal-li a#compose').html(
    48                 $( '<span></span>' ).html( $( '#compose-personal-li a#compose' ).html() ).addClass( 'bp-screen-reader-text' )
    49             );
    50             $( '#compose-personal-li a#compose' ).addClass( 'button' );
    5147
    5248            // Then listen to nav click and load the appropriate view
     
    929925
    930926            if ( isChecked ) {
    931                 $( this.el ).find( '.bulk-actions-wrap' ).removeClass( 'bp-hide' );
     927                $( this.el ).find( '.bulk-actions-wrap' ).removeClass( 'bp-hide' ).addClass( 'bp-show' );
    932928            } else {
    933929                $( this.el ).find( '.bulk-actions-wrap' ).addClass( 'bp-hide' );
  • trunk/src/bp-templates/bp-nouveau/sass/_nouveau_messages.scss

    r11913 r11916  
    66.message-action-star:before,
    77.message-action-unstar:before,
    8 .bp-navs ul li#compose-personal-li a#compose:before,
    98.message-action-view:before,
    109.message-action-delete:before {
     
    1312}
    1413
    15 .bp-navs ul li#compose-personal-li a#compose:before {
    16     font-size: 22px;
    17 }
    18 
    1914.message-action-star:before {
    2015    color: #aaa;
     
    4843    }
    4944}
    50 
    51 // Compose Icon
    52 li#compose-personal-li {
    53 
    54     &.last {
    55         margin-top: 0;
    56     }
    57 
    58     a#compose {
    59         display: inline-block;
    60         padding: 1px 6px;
    61     }
    62 
    63     a#compose:before {
    64         content: "\f464";
    65     }
    66 
    67     a#compose:focus,
    68     a#compose:hover {
    69         background: #eee;
    70         color: #e8861e;
    71     }
    72 
    73 } // close li#compose-personal-li
    7445
    7546// Visual message threads & preview pane styles
     
    12495            @include center-vert();
    12596            @include box-item-size(1, 2, 5%);
    126 
    127             label {
    128                 float: left;
    129                 margin-left: $marg-xsml;
    130                 text-align: center;
    131                 width: 5%;
    132             }
    13397        }
    13498
Note: See TracChangeset for help on using the changeset viewer.