Changeset 11885 for trunk/src/bp-activity/classes/class-bp-activity-component.php

Timestamp:

03/05/2018 12:00:25 AM (7 years ago)

Author:

r-a-y

Message:

Activity: Conditionally load action and screen functions.

This commit conditionally loads action and screen function code for the
Activity component, utilizing the 'bp_late_include' hook introduced in
r11884.

Previously, we loaded these functions at all times, which is unnecessary
when a user is not on an BuddyPress activity page. Now, we only load this
code when needed.

A special case is required for PHPUnit as PHPUnit doesn't like conditional-
included files when running multiple unit tests. So for PHPUnit, we
include all action and screen code at once, just like before.

See #7218.

File:

• trunk/src/bp-activity/classes/class-bp-activity-component.php (modified) (2 diffs)

trunk/src/bp-activity/classes/class-bp-activity-component.php

@@ -52 +52 @@
         $includes = array(
             'cssjs',
-            'actions',
-            'screens',
             'filters',
             'adminbar',
@@ -84 +82 @@
 
         parent::includes( $includes );
+    }
+
+    /**
+     * Late includes method.
+     *
+     * Only load up certain code when on specific pages.
+     *
+     * @since 3.0.0
+     */
+    public function late_includes() {
+        // Bail if PHPUnit is running.
+        if ( defined( 'BP_TESTS_DIR' ) ) {
+            return;
+        }
+
+        /*
+         * Load activity action and screen code if PHPUnit isn't running.
+         *
+         * For PHPUnit, we load these files in tests/phpunit/includes/install.php.
+         */
+        if ( bp_is_current_component( 'activity' ) ) {
+            // Authenticated actions - Only fires when JS is disabled.
+            if ( is_user_logged_in() &&
+                in_array( bp_current_action(), array( 'delete', 'spam', 'post', 'reply', 'favorite', 'unfavorite' ), true )
+            ) {
+                require $this->path . 'bp-activity/actions/' . bp_current_action() . '.php';
+            }
+
+            // RSS feeds.
+            if ( bp_is_current_action( 'feed' ) || bp_is_action_variable( 'feed', 0 ) ) {
+                require $this->path . 'bp-activity/actions/feeds.php';
+            }
+
+            // Screens - Directory.
+            if ( bp_is_activity_directory() ) {
+                require $this->path . 'bp-activity/screens/directory.php';
+            }
+
+            // Screens - User main nav.
+            if ( bp_is_user() ) {
+                require $this->path . 'bp-activity/screens/just-me.php';
+            }
+
+            // Screens - User secondary nav.
+            if ( bp_is_user() && in_array( bp_current_action(), array( 'friends', 'groups', 'favorites', 'mentions' ), true ) ) {
+                require $this->path . 'bp-activity/screens/' . bp_current_action() . '.php';
+            }
+
+            // Screens - Single permalink.
+            if ( bp_is_current_action( 'p' ) || is_numeric( bp_current_action() ) ) {
+                require $this->path . 'bp-activity/screens/permalink.php';
+            }
+
+            // Theme compatibility.
+            new BP_Activity_Theme_Compat();
+        }
+
+        // Activity notifications HTML table.
+        if ( bp_is_user_settings_notifications() ) {
+            require $this->path . 'bp-activity/screens/settings-email.php';
+        }
     }