Changeset 11880

Timestamp:

03/04/2018 07:55:02 PM (7 years ago)

Author:

r-a-y

Message:

Unit Tests: Improve performance of multisite directory page test.

The unit test in question was introduced in #6226.

Basically, the test needed to match a specific WordPress post ID.
Previously, the test did this by creating posts in a loop(!) until it
matched the post ID. However, there is a parameter in wp_insert_post()
that allows you to set the post ID from the get-go - 'import_id'.

This commit switches to using the 'import_id' parameter to create the
WordPress post and should speed up this test considerably.

Fixes #7709.

File:

• trunk/tests/phpunit/testcases/core/functions/bpCoreGetDirectoryPageIds.php (modified) (1 diff)

trunk/tests/phpunit/testcases/core/functions/bpCoreGetDirectoryPageIds.php

@@ -266 +266 @@
         $b1 = self::factory()->blog->create( array( 'user_id' => $u ) );
 
-        // switch to blog and create some dummy posts until we reach a post ID that
-        // matches our BP activity page ID
+        // Switch to blog and create a post with the same BP activity page ID.
         switch_to_blog( $b1 );
-        $p = self::factory()->post->create();
-        while( $p <= $dir_pages->activity->id ) {
-            $p = self::factory()->post->create();
-        }
+        $p = self::factory()->post->create( array(
+            'import_id' => $dir_pages->activity->id
+        ) );
 
         // delete the post that matches the BP activity page ID on this sub-site