Changeset 11865 for trunk/src/bp-friends/bp-friends-filters.php

Timestamp:

02/27/2018 01:29:33 PM (7 years ago)

Author:

dcavins

Message:

Change check in BP_Friends_Friendship::check_is_friend().

In BP2.5, we introduced a new friendship caching mechanism that created a new cache item containing all of a user's friendships. This approach worked well on sites with fewer friendships per user, but caused cache access issues on sites with lots of friendship connections.

This update replaces the cache-intensive change to BP_Friends_Friendship::check_is_friend() with a return to a single lookup to determine friendship status between two users. To minimize SQL lookups, individual friendships are now cached, and a new cache-warming function has been added to bulk update these new cache items: BP_Friends_Friendship::update_bp_friends_cache().

Props januzi_pl, boonebgorges, r-a-y, djpaul, dcavins.

Fixes #7436.

File:

• trunk/src/bp-friends/bp-friends-filters.php (modified) (1 diff)

trunk/src/bp-friends/bp-friends-filters.php

@@ -35 +35 @@
     $maybe_friend_ids = wp_parse_id_list( $user_ids_sql );
 
+    // Bulk prepare the friendship cache.
+    BP_Friends_Friendship::update_bp_friends_cache( $user_id, $maybe_friend_ids );
+
     foreach ( $maybe_friend_ids as $friend_id ) {
         $status = BP_Friends_Friendship::check_is_friend( $user_id, $friend_id );