Changeset 11859

Timestamp:

02/17/2018 12:15:20 PM (7 years ago)

Author:

hnla

Message:

Nouveau: Correct non showing of single comment reply in activity stream

in the activity JS we count replies and if less than one we attempt to ensure that we do show a comment where initially all are hidden, this was actioned by comparing counts and removing the 'hide' actions/classes for the last-child element, this fails if the first or only element.

Commit addresses this by removing the .last() function.

Todo: This comments section of scripting has proven problematic & this may not be a final solution, more testing would be useful in general for commenst display.

File:

• trunk/src/bp-templates/bp-nouveau/js/buddypress-activity.js (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/js/buddypress-activity.js

@@ -356 +356 @@
                 } );
 
-                // If all parents are hidden, reveal at least the last on. It seems very risky to manipulate the DOM to keep exactly 5 comments!
+                // If all parents are hidden, reveal at least one. It seems very risky to manipulate the DOM to keep exactly 5 comments!
                 if ( $( comment_parents ).children( '.bp-hidden' ).length === $( comment_parents ).children( 'li' ).length - 1 && $( comment_parents ).find( 'li.show-all' ) ) {
-                    $( comment_parents ).children( 'li' ).last().removeClass( 'bp-hidden' ).toggle();
+                    $( comment_parents ).children( 'li' ).removeClass( 'bp-hidden' ).toggle();
                 }
             } );