Changeset 11858 for trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php

Timestamp:

02/15/2018 03:52:40 PM (8 years ago)

Author:

espellcaste

Message:

Make use of bp_is_post_request() instead of hardcoding POST verifications directly.

BuddyPress is not making use of the bp_is_post_request() in several ajax scenarios to confirm if the post request is indeed a POST request. Instead, it is hardcoding the check directly. This change updates those places making use of this function.

Props DjPaul

Fixes #7684

File:

• trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php (modified) (7 diffs)

trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php

@@ -86 +86 @@
  */
 function bp_nouveau_ajax_mark_activity_favorite() {
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error();
     }
@@ -127 +126 @@
  */
 function bp_nouveau_ajax_unmark_activity_favorite() {
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error();
     }
@@ -164 +162 @@
  */
 function bp_nouveau_ajax_clear_new_mentions() {
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error();
     }
@@ -194 +191 @@
 
     // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error( $response );
     }
@@ -266 +263 @@
 
     // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error( $response );
     }
@@ -327 +324 @@
 
     // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error( $response );
     }
@@ -564 +561 @@
 
     // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error( $response );
     }