Changeset 11858 for trunk/src/bp-settings/bp-settings-actions.php

Timestamp:

02/15/2018 03:52:40 PM (8 years ago)

Author:

espellcaste

Message:

Make use of bp_is_post_request() instead of hardcoding POST verifications directly.

BuddyPress is not making use of the bp_is_post_request() in several ajax scenarios to confirm if the post request is indeed a POST request. Instead, it is hardcoding the check directly. This change updates those places making use of this function.

Props DjPaul

Fixes #7684

File:

• trunk/src/bp-settings/bp-settings-actions.php (modified) (4 diffs)

trunk/src/bp-settings/bp-settings-actions.php

@@ -28 +28 @@
  */
 function bp_settings_action_general() {
-
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) )
-        return;
+    if ( ! bp_is_post_request() ) {
+        return;
+    }
 
     // Bail if no submit action.
-    if ( ! isset( $_POST['submit'] ) )
-        return;
+    if ( ! isset( $_POST['submit'] ) ) {
+        return;
+    }
 
     // Bail if not in settings.
-    if ( ! bp_is_settings_component() || ! bp_is_current_action( 'general' ) )
-        return;
+    if ( ! bp_is_settings_component() || ! bp_is_current_action( 'general' ) ) {
+        return;
+    }
 
     // 404 if there are any additional action variables attached
@@ -260 +261 @@
  */
 function bp_settings_action_notifications() {
-
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) )
-        return;
+    if ( ! bp_is_post_request() ) {
+        return;
+    }
 
     // Bail if no submit action.
-    if ( ! isset( $_POST['submit'] ) )
-        return;
+    if ( ! isset( $_POST['submit'] ) ) {
+        return;
+    }
 
     // Bail if not in settings.
-    if ( ! bp_is_settings_component() || ! bp_is_current_action( 'notifications' ) )
+    if ( ! bp_is_settings_component() || ! bp_is_current_action( 'notifications' ) ) {
         return false;
+    }
 
     // 404 if there are any additional action variables attached
@@ -307 +309 @@
  */
 function bp_settings_action_capabilities() {
-
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) )
-        return;
+    if ( ! bp_is_post_request() ) {
+        return;
+    }
 
     // Bail if no submit action.
-    if ( ! isset( $_POST['capabilities-submit'] ) )
-        return;
+    if ( ! isset( $_POST['capabilities-submit'] ) ) {
+        return;
+    }
 
     // Bail if not in settings.
-    if ( ! bp_is_settings_component() || ! bp_is_current_action( 'capabilities' ) )
+    if ( ! bp_is_settings_component() || ! bp_is_current_action( 'capabilities' ) ) {
         return false;
+    }
 
     // 404 if there are any additional action variables attached
@@ -381 +384 @@
  */
 function bp_settings_action_delete_account() {
-
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) )
-        return;
+    if ( ! bp_is_post_request() ) {
+        return;
+    }
 
     // Bail if no submit action.
-    if ( ! isset( $_POST['delete-account-understand'] ) )
-        return;
+    if ( ! isset( $_POST['delete-account-understand'] ) ) {
+        return;
+    }
 
     // Bail if not in settings.
-    if ( ! bp_is_settings_component() || ! bp_is_current_action( 'delete-account' ) )
+    if ( ! bp_is_settings_component() || ! bp_is_current_action( 'delete-account' ) ) {
         return false;
+    }
 
     // 404 if there are any additional action variables attached