Changeset 11858 for trunk/src/bp-core/bp-core-avatars.php

Timestamp:

02/15/2018 03:52:40 PM (8 years ago)

Author:

espellcaste

Message:

Make use of bp_is_post_request() instead of hardcoding POST verifications directly.

BuddyPress is not making use of the bp_is_post_request() in several ajax scenarios to confirm if the post request is indeed a POST request. Instead, it is hardcoding the check directly. This change updates those places making use of this function.

Props DjPaul

Fixes #7684

File:

• trunk/src/bp-core/bp-core-avatars.php (modified) (3 diffs)

trunk/src/bp-core/bp-core-avatars.php

@@ -810 +810 @@
  */
 function bp_avatar_ajax_delete() {
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error();
     }
@@ -953 +952 @@
  */
 function bp_avatar_ajax_upload() {
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_die();
     }
@@ -1238 +1236 @@
  */
 function bp_avatar_ajax_set() {
-    // Bail if not a POST action.
-    if ( 'POST' !== strtoupper( $_SERVER['REQUEST_METHOD'] ) ) {
+    if ( ! bp_is_post_request() ) {
         wp_send_json_error();
     }