Changeset 11847

Timestamp:

02/07/2018 07:04:13 AM (9 years ago)

Author:

offereins

Message:

XProfile: delete field metadata when a field is deleted

Previously, field metadata remained in the database after a profile field
was deleted. Using bp_xprofile_delete_meta() all field metadata will
now be deleted while all relevant metadata hooks are fired.

Adds unit tests for default and custom field metadata.

Fixes #6658.

Location:

trunk

Files:

• src/bp-xprofile/classes/class-bp-xprofile-field.php (modified) (1 diff)
• tests/phpunit/testcases/xprofile/class-bp-xprofile-field.php (modified) (1 diff)

trunk/src/bp-xprofile/classes/class-bp-xprofile-field.php

@@ -361 +361 @@
                         return false;
                 }
+
+                // Delete all metadata for this field.
+                bp_xprofile_delete_meta( $this->id, 'field' );
 
                 // Delete the data in the DB for this field.

trunk/tests/phpunit/testcases/xprofile/class-bp-xprofile-field.php

@@ -225 +225 @@
                 $this->set_current_user( $old_user );
         }
+
+        /**
+         * @ticket BP6658
+         */
+        public function test_delete_field_should_delete_default_field_metadata() {
+                $group = self::factory()->xprofile_group->create();
+                $field = self::factory()->xprofile_field->create( array(
+                        'field_group_id' => $group
+                ) );
+
+                $field_obj = new BP_XProfile_Field( $field );
+                $field_obj->delete();
+
+                $value = bp_xprofile_get_meta( $field, 'field', 'default_visibility' );
+                $this->assertEmpty( $value );
+        }
+
+        /**
+         * @ticket BP6658
+         */
+        public function test_delete_field_should_delete_custom_field_metadata() {
+                $group = self::factory()->xprofile_group->create();
+                $field = self::factory()->xprofile_field->create( array(
+                        'field_group_id' => $group
+                ) );
+
+                bp_xprofile_update_meta( $field, 'field', 'custom', 'metadata' );
+
+                $field_obj = new BP_XProfile_Field( $field );
+                $field_obj->delete();
+
+                $value = bp_xprofile_get_meta( $field, 'field', 'custom' );
+                $this->assertEmpty( $value );
+        }
 }