Changeset 11838 for trunk/src/bp-groups/classes/class-bp-groups-group.php

Timestamp:

02/01/2018 08:10:42 PM (8 years ago)

Author:

boonebgorges

Message:

Groups: Admin/mod queries should respect when a group has no admins/mods.

Without this patch, groups without admins or mods can trigger a lookup of
every user on the installation.

Props cyclic.
Fixes #7677.

File:

• trunk/src/bp-groups/classes/class-bp-groups-group.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -561 +561 @@
         $mod_ids_plucked = wp_list_pluck( $mod_ids, 'user_id' );
 
-        $admin_mod_users = get_users( array(
-            'include' => array_merge( $admin_ids_plucked, $mod_ids_plucked ),
-            'blog_id' => null,
-        ) );
+        $admin_mod_ids = array_merge( $admin_ids_plucked, $mod_ids_plucked );
+        $admin_mod_users = array();
+
+        if ( ! empty( $admin_mod_ids ) ) {
+            $admin_mod_users = get_users( array(
+                'include' => $admin_mod_ids,
+                'blog_id' => null,
+            ) );
+        }
 
         $admin_objects = $mod_objects = array();