Changeset 11838

Timestamp:

02/01/2018 08:10:42 PM (7 years ago)

Author:

boonebgorges

Message:

Groups: Admin/mod queries should respect when a group has no admins/mods.

Without this patch, groups without admins or mods can trigger a lookup of
every user on the installation.

Props cyclic.
Fixes #7677.

Location:

trunk

Files:

• src/bp-groups/classes/class-bp-groups-group.php (modified) (1 diff)
• tests/phpunit/testcases/groups/class-bp-groups-group.php (modified) (1 diff)

trunk/src/bp-groups/classes/class-bp-groups-group.php

@@ -561 +561 @@
         $mod_ids_plucked = wp_list_pluck( $mod_ids, 'user_id' );
 
-        $admin_mod_users = get_users( array(
-            'include' => array_merge( $admin_ids_plucked, $mod_ids_plucked ),
-            'blog_id' => null,
-        ) );
+        $admin_mod_ids = array_merge( $admin_ids_plucked, $mod_ids_plucked );
+        $admin_mod_users = array();
+
+        if ( ! empty( $admin_mod_ids ) ) {
+            $admin_mod_users = get_users( array(
+                'include' => $admin_mod_ids,
+                'blog_id' => null,
+            ) );
+        }
 
         $admin_objects = $mod_objects = array();

trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php

@@ -1517 +1517 @@
 
     /**
+     * @ticket BP7677
+     */
+    public function test_demoting_sole_admin() {
+        $user = self::factory()->user->create_and_get();
+        $group = self::factory()->group->create_and_get( array(
+            'creator_id' => $user->ID,
+        ) );
+        $member = new BP_Groups_Member( $user->ID, $group->id );
+        $member->demote();
+
+        $this->assertEmpty( $group->admins );
+        $this->assertEmpty( $group->mods );
+    }
+
+    /**
      * @ticket BP5451
      */