Changeset 11825 for trunk/src/bp-templates/bp-nouveau/buddypress/members/single/activity.php

Timestamp:

01/27/2018 12:21:27 PM (7 years ago)

Author:

hnla

Message:

Nouveau: re-factor activity template loops main dir & members single

The loops JS inject all act content & loop messages into a ul construct regardless of whether there is true list loop content e.g no activity found or loading loop messages, single items are not a list, we should only show a ul if rendering loop content, this also impacts styles where messages look odd in a li element.

Commit moves the JS required hooks & 'data-bp-list="activity"' up a level to the wrapper element, re-factors the 'if bp_has_activities' to wrap only the ul which moves into the activity-loop.php template, moves the message functions out of the loops & removes unnecessary markup for messages.

File:

• trunk/src/bp-templates/bp-nouveau/buddypress/members/single/activity.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/buddypress/members/single/activity.php

@@ -23 +23 @@
 <?php bp_nouveau_member_hook( 'before', 'activity_content' ); ?>
 
-<div class="activity single-user">
+<div id="activity-stream" class="activity single-user" data-bp-list="activity">
 
-    <ul id="activity-stream" class="<?php bp_nouveau_loop_classes(); ?>" data-bp-list="activity">
+    <div id="bp-ajax-loader"><?php bp_nouveau_user_feedback( 'member-activity-loading' ); ?></div>
 
-        <li id="bp-ajax-loader"><?php bp_nouveau_user_feedback( 'member-activity-loading' ); ?></li>
+    <ul  class="<?php bp_nouveau_loop_classes(); ?>" >
 
     </ul>