Changeset 11814 for trunk/src/bp-core/bp-core-buddybar.php

Timestamp:

01/20/2018 09:39:27 PM (7 years ago)

Author:

r-a-y

Message:

Navigation: Restricted subnav menu pages should redirect instead of throwing a 404.

Back in BuddyPress 2.6.0, we refactored the way we register menu items with
the BP Navigation API (see #6534).

The problem is we missed an instance during the refactor. This caused
restricted subnav pages (those set with the 'user_has_access' parameter
to false in bp_core_new_subnav_item()) to 404 instead of being redirected
away.

Commit fixes this problem.

See #7659.

File:

• trunk/src/bp-core/bp-core-buddybar.php (modified) (1 diff)

trunk/src/bp-core/bp-core-buddybar.php

@@ -609 +609 @@
 
     $parent_nav = $bp->{$component}->nav->get_primary( array( 'slug' => $r['parent_slug'] ), false );
+    if ( ! $parent_nav ) {
+        return ;
+    }
+
+    $parent_nav = reset( $parent_nav );
 
     // If we *do* meet condition (2), then the added subnav item is currently being requested.