Changeset 11780 for trunk/src/bp-groups/bp-groups-template.php

Timestamp:

01/02/2018 01:04:42 PM (7 years ago)

Author:

djpaul

Message:

Groups: reinstate functions bp_is_group_forums_active(), bp_group_new_topic_button(), bp_get_group_new_topic_button().

The first function has been reinstated for compatibility with third-party plugins, "BuddyPress for Sensei" and "BuddyPress for LearnDash".

The latter two functions rendered a "new topic" button on a Group screen.
Current proposal is that bbPress is updated to add this back, because otherwise we have to make assumptions about bbPress' permalinks, or rely on calling a bbPress function (which feels conceptually wrong from an integration perspective).

Also fix a PHP Notice caused by an incomplete prior removal of bp_group_new_topic_button() (see bp-legacy/buddypress-functions.php).

See #5351

File:

• trunk/src/bp-groups/bp-groups-template.php (modified) (1 diff)

trunk/src/bp-groups/bp-groups-template.php

@@ -3190 +3190 @@
 
 /**
+ * Output a 'New Topic' button for a group.
+ *
+ * @since 1.2.7
+ * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+ *
+ * @param BP_Groups_Group|bool $group The BP Groups_Group object if passed, boolean false if not passed.
+ */
+function bp_group_new_topic_button( $group = false ) {
+}
+
+    /**
+     * Return a 'New Topic' button for a group.
+     *
+     * @since 1.2.7
+     * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+     *
+     * @param BP_Groups_Group|bool $group The BP Groups_Group object if passed, boolean false if not passed.
+     *
+     * @return false
+     */
+    function bp_get_group_new_topic_button( $group = false ) {
+        return false;
+    }
+
+/**
  * Output button to join a group.
  *