Changeset 11780

Timestamp:

01/02/2018 01:04:42 PM (7 years ago)

Author:

djpaul

Message:

Groups: reinstate functions bp_is_group_forums_active(), bp_group_new_topic_button(), bp_get_group_new_topic_button().

The first function has been reinstated for compatibility with third-party plugins, "BuddyPress for Sensei" and "BuddyPress for LearnDash".

The latter two functions rendered a "new topic" button on a Group screen.
Current proposal is that bbPress is updated to add this back, because otherwise we have to make assumptions about bbPress' permalinks, or rely on calling a bbPress function (which feels conceptually wrong from an integration perspective).

Also fix a PHP Notice caused by an incomplete prior removal of bp_group_new_topic_button() (see bp-legacy/buddypress-functions.php).

See #5351

Location:

trunk/src

Files:

• bp-core/bp-core-options.php (modified) (1 diff)
• bp-groups/bp-groups-template.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress-functions.php (modified) (1 diff)

trunk/src/bp-core/bp-core-options.php

@@ -690 +690 @@
 
 /**
+ * Check whether bbPress plugin-powered Group Forums are enabled.
+ *
+ * @since 1.6.0
+ * @since 3.0.0 $default argument's default value changed from true to false.
+ * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+ *
+ * @param bool $default Optional. Fallback value if not found in the database.
+ *                      Default: false.
+ * @return bool True if group forums are active, otherwise false.
+ */
+function bp_is_group_forums_active( $default = false ) {
+    $is_active = function_exists( 'bbp_is_group_forums_active' ) ? bbp_is_group_forums_active( $default ) : $default;
+
+    /**
+     * Filters whether or not bbPress plugin-powered Group Forums are enabled.
+     *
+     * @since 1.6.0
+     * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+     *
+     * @param bool $value Whether or not bbPress plugin-powered Group Forums are enabled.
+     */
+    return (bool) apply_filters( 'bp_is_group_forums_active', $is_active );
+}
+
+/**
  * Check whether Akismet is enabled.
  *

trunk/src/bp-groups/bp-groups-template.php

@@ -3190 +3190 @@
 
 /**
+ * Output a 'New Topic' button for a group.
+ *
+ * @since 1.2.7
+ * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+ *
+ * @param BP_Groups_Group|bool $group The BP Groups_Group object if passed, boolean false if not passed.
+ */
+function bp_group_new_topic_button( $group = false ) {
+}
+
+    /**
+     * Return a 'New Topic' button for a group.
+     *
+     * @since 1.2.7
+     * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+     *
+     * @param BP_Groups_Group|bool $group The BP Groups_Group object if passed, boolean false if not passed.
+     *
+     * @return false
+     */
+    function bp_get_group_new_topic_button( $group = false ) {
+        return false;
+    }
+
+/**
  * Output button to join a group.
  *

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -107 +107 @@
             if ( bp_is_active( 'groups' ) ) {
                 add_action( 'bp_group_header_actions',          'bp_group_join_button',               5           );
-                add_action( 'bp_group_header_actions',          'bp_group_new_topic_button',         20           );
                 add_action( 'bp_directory_groups_actions',      'bp_group_join_button'                            );
                 add_action( 'bp_groups_directory_group_filter', 'bp_legacy_theme_group_create_nav', 999           );