Changeset 11763 for trunk/src/bp-core/bp-core-functions.php

Timestamp:

12/08/2017 12:22:09 AM (7 years ago)

Author:

djpaul

Message:

Retire Legacy Forums.

"Legacy Forums" is what we now call the bundled version of bbPress 1 that has shipped with BuddyPress for over nine years. The Legacy Forums codebase/features are many years stagnant, and it has been almost completely hidden from the UI for the past five years.

Legacy Forums were replaced by bbPress 2, which is its own plugin, and we've been promoting its integration with BuddyPress for a long time. Most significantly, bbPress 1 only runs on WordPress versions older than 4.7, because of a BackPress conflict (which is nested inside bbPress 1) with WordPress 4.7's WP_Taxonomy class.

If your site is still using Legacy Forums, you will need to migrate to bbPress 2 to run BuddyPress 3.0. See ​https://bpdevel.wordpress.com/2017/12/07/legacy-forums-support-will-be/ for more information.

Fixes #5351
See #7502

File:

• trunk/src/bp-core/bp-core-functions.php (modified) (6 diffs)

trunk/src/bp-core/bp-core-functions.php

@@ -446 +446 @@
 }
 
+
+/**
+ * Return the parent forum ID for the Legacy Forums abstraction layer.
+ *
+ * @since 1.5.0
+ * @since 3.0.0 Supported for compatibility with bbPress 2.
+ *
+ * @return int Forum ID.
+ */
+function bp_forums_parent_forum_id() {
+
+    /**
+     * Filters the parent forum ID for the bbPress abstraction layer.
+     *
+     * @since 1.5.0
+     *
+     * @param int BP_FORUMS_PARENT_FORUM_ID The Parent forum ID constant.
+     */
+    return apply_filters( 'bp_forums_parent_forum_id', BP_FORUMS_PARENT_FORUM_ID );
+}
+
 /** Directory *****************************************************************/
 
@@ -467 +488 @@
         'notifications',
     );
-
-    // Only add legacy forums if it is enabled
-    // prevents conflicts with bbPress, which also uses the same 'forums' id.
-    if ( class_exists( 'BP_Forums_Component' ) ) {
-        $components[] = 'forums';
-    }
 
     return $components;
@@ -1731 +1746 @@
 
 /**
- * Are oembeds allowed in forum posts?
- *
- * @since 1.5.0
- *
- * @return bool False when forum post embed support is disabled; true when
- *              enabled. Default: true.
- */
-function bp_use_embed_in_forum_posts() {
-
-    /**
-     * Filters whether or not oEmbeds are allowed in forum posts.
-     *
-     * @since 1.5.0
-     *
-     * @param bool $value Whether or not oEmbeds are allowed.
-     */
-    return apply_filters( 'bp_use_embed_in_forum_posts', !defined( 'BP_EMBED_DISABLE_FORUM_POSTS' ) || !BP_EMBED_DISABLE_FORUM_POSTS );
-}
-
-/**
  * Are oembeds allowed in private messages?
  *
@@ -2356 +2351 @@
                 break;
 
-            case 'forums':
-                $slug = bp_is_active( 'forums' ) ? bp_get_forums_root_slug() : '';
-                $query_string = '/?fs=';
-                break;
-
             case 'groups':
                 $slug = bp_is_active( 'groups' ) ? bp_get_groups_root_slug() : '';
@@ -2464 +2454 @@
 
     $retired_components = array(
-        'forums' => array(
-            'title'       => __( 'Group Forums', 'buddypress' ),
-            'description' => sprintf( __( 'BuddyPress Forums are retired. Use %s.', 'buddypress' ), '<a href="https://bbpress.org/">bbPress</a>' )
-        ),
     );
 
@@ -2498 +2484 @@
             'title'       => __( 'User Groups', 'buddypress' ),
             'description' => __( 'Groups allow your users to organize themselves into specific public, private or hidden sections with separate activity streams and member listings.', 'buddypress' )
-        ),
-        'forums'   => array(
-            'title'       => __( 'Group Forums (Legacy)', 'buddypress' ),
-            'description' => __( 'Group forums allow for focused, bulletin-board style conversations.', 'buddypress' )
         ),
         'blogs'    => array(