Changeset 11719 for trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/activity/form.php

Timestamp:

11/01/2017 09:01:03 PM (8 years ago)

Author:

mercime

Message:

Accessibility: Replace <a href="#"> with Semantic Elements.

Using semantic markup like the button which is specifically meant for controlling a user interface instead of a fragment identifier separator # value with the href attribute, helps assistive technologies identify the real purpose of the UI element across all browsers and all devices.

Fixes #7612.

File:

• trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/activity/form.php (modified) (2 diffs)

trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/activity/form.php

@@ -23 +23 @@
 
 <script type="text/html" id="tmpl-activity-post-form-buttons">
-    <a href="#" class="button dashicons {{data.icon}}" data-button="{{data.id}}"><span class="bp-screen-reader-text">{{data.caption}}</span></a>
+    <button type="button" class="button dashicons {{data.icon}}" data-button="{{data.id}}"><span class="bp-screen-reader-text">{{data.caption}}</span></button>
 </script>
 
@@ -38 +38 @@
 
     <# if ( data.selected ) { #>
-        <a href="#" class="bp-remove-item dashicons dashicons-no" data-item_id="{{data.id}}">
+        <button type="button" class="bp-remove-item dashicons dashicons-no" data-item_id="{{data.id}}">
             <span class="bp-screen-reader-text"><?php esc_html_e( 'Remove item', 'buddypress' ); ?></span>
-        </a>
+        </button>
     <# } #>
 </script>