Changeset 11707

Timestamp:

09/28/2017 08:38:32 PM (7 years ago)

Author:

hnla

Message:

BP Nouveau - default search text output strings

Commit corrects erroneous 'echo' causing double rendering of string in placeholder attr & label.
Adds an empty( $text ) check on the object query setting bp core default text return to allow user set param to pass through.

Function still requires better understanding of the bp_get_search_default_text( $objects['secondary'] ) use.

File:

• trunk/src/bp-templates/bp-nouveau/includes/template-tags.php (modified) (1 diff)

trunk/src/bp-templates/bp-nouveau/includes/template-tags.php

@@ -1683 +1683 @@
  * @return string The default search text.
  *
- * @todo 05/09/17 added  '! $text' to $object query as it's not returning output as expected & not returning user set params
- * This needs looking at as var_dump the query and it shows user set string yet won't return it?! - hnla
+ * @todo 28/09/17 added  'empty( $text )' check to $object query as it wasn't returning output as expected & not returning user set params
+ * This may require further examination - hnla
  */
 function bp_nouveau_search_default_text( $text = '', $is_attr = true ) {
     $objects = bp_nouveau_get_search_objects();
 
-    if ( ! empty( $objects['secondary'] ) && ! $text ) {
-    echo    $text = bp_get_search_default_text( $objects['secondary'] );
+    if ( ! empty( $objects['secondary'] ) && empty( $text ) ) {
+        $text = bp_get_search_default_text( $objects['secondary'] );
     }