Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
06/22/2017 08:09:27 PM (9 years ago)
Author:
djpaul
Message:

HTML <a> elements should never have title attributes.

Accessible support is too inconsistent across software and platforms.
In a small number of places (mainly legacy templates) where the link text was a meaningless value, the attribute was swapped out for aria-label, which reliably overides the link text readout.

Props rianrietveld

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-templates/bp-legacy/buddypress/groups/single/forum/topic.php

    r11591 r11606  
    127127                                                do_action( 'bp_group_forum_post_meta' ); ?>
    128128
    129                                                 <a href="#post-<?php bp_the_topic_post_id(); ?>" title="<?php esc_attr_e( 'Permanent link to this post', 'buddypress' ); ?>">#</a>
     129                                                <a href="#post-<?php bp_the_topic_post_id(); ?>" aria-label="<?php esc_attr_e( 'Permanent link to this post', 'buddypress' ); ?>">#</a>
    130130                                        </div>
    131131                                </li>
Note: See TracChangeset for help on using the changeset viewer.