Skip to:
Content

BuddyPress.org


Ignore:
Timestamp:
06/22/2017 08:09:27 PM (7 years ago)
Author:
djpaul
Message:

HTML <a> elements should never have title attributes.

Accessible support is too inconsistent across software and platforms.
In a small number of places (mainly legacy templates) where the link text was a meaningless value, the attribute was swapped out for aria-label, which reliably overides the link text readout.

Props rianrietveld

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/bp-templates/bp-legacy/buddypress/forums/forums-loop.php

    r11591 r11606  
    7272            <tr class="<?php bp_the_topic_css_class(); ?>">
    7373                <td class="td-title">
    74                     <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>" title="<?php esc_attr_e( 'Permanent link to this post', 'buddypress' ); ?>">
     74                    <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>">
    7575
    7676                        <?php bp_the_topic_title(); ?>
     
    8787                                <?php
    8888                                    $topic_in = '<a href="' . bp_get_the_topic_object_permalink() . '">' . bp_get_the_topic_object_avatar( 'type=thumb&width=20&height=20' ) . '</a>' .
    89                                                     '<a href="' . bp_get_the_topic_object_permalink() . '" title="' . bp_get_the_topic_object_name() . '">' . bp_get_the_topic_object_name() .'</a>';
     89                                                    '<a href="' . bp_get_the_topic_object_permalink() . '">' . bp_get_the_topic_object_name() .'</a>';
    9090
    9191                                    /* translators: "started by [poster] in [forum]" */
Note: See TracChangeset for help on using the changeset viewer.