Changeset 11606 for trunk/src/bp-templates/bp-legacy/buddypress/forums/forums-loop.php

Timestamp:

06/22/2017 08:09:27 PM (9 years ago)

Author:

djpaul

Message:

HTML <a> elements should never have title attributes.

Accessible support is too inconsistent across software and platforms.
In a small number of places (mainly legacy templates) where the link text was a meaningless value, the attribute was swapped out for aria-label, which reliably overides the link text readout.

Props rianrietveld

File:

• trunk/src/bp-templates/bp-legacy/buddypress/forums/forums-loop.php (modified) (2 diffs)

trunk/src/bp-templates/bp-legacy/buddypress/forums/forums-loop.php

@@ -72 +72 @@
                         <tr class="<?php bp_the_topic_css_class(); ?>">
                                 <td class="td-title">
-                                        <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>" title="<?php esc_attr_e( 'Permanent link to this post', 'buddypress' ); ?>">
+                                        <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>">
 
                                                 <?php bp_the_topic_title(); ?>
@@ -87 +87 @@
                                                                 <?php
                                                                         $topic_in = '<a href="' . bp_get_the_topic_object_permalink() . '">' . bp_get_the_topic_object_avatar( 'type=thumb&width=20&height=20' ) . '</a>' .
-                                                                                                        '<a href="' . bp_get_the_topic_object_permalink() . '" title="' . bp_get_the_topic_object_name() . '">' . bp_get_the_topic_object_name() .'</a>';
+                                                                                                        '<a href="' . bp_get_the_topic_object_permalink() . '">' . bp_get_the_topic_object_name() .'</a>';
 
                                                                         /* translators: "started by [poster] in [forum]" */