Changeset 11606 for trunk/src/bp-messages/bp-messages-notifications.php

Timestamp:

06/22/2017 08:09:27 PM (7 years ago)

Author:

djpaul

Message:

HTML <a> elements should never have title attributes.

Accessible support is too inconsistent across software and platforms.
In a small number of places (mainly legacy templates) where the link text was a meaningless value, the attribute was swapped out for aria-label, which reliably overides the link text readout.

Props rianrietveld

File:

• trunk/src/bp-messages/bp-messages-notifications.php (modified) (1 diff)

trunk/src/bp-messages/bp-messages-notifications.php

@@ -54 +54 @@
         if ( 'string' === $format ) {
             if ( ! empty( $link ) ) {
-                $return = '<a href="' . esc_url( $link ) . '" title="' . esc_attr( $title ) . '">' . esc_html( $text ) . '</a>';
+                $return = '<a href="' . esc_url( $link ) . '">' . esc_html( $text ) . '</a>';
             } else {
                 $return = esc_html( $text );