Changeset 11606 for trunk/src/bp-groups/bp-groups-notifications.php

Timestamp:

06/22/2017 08:09:27 PM (8 years ago)

Author:

djpaul

Message:

HTML <a> elements should never have title attributes.

Accessible support is too inconsistent across software and platforms.
In a small number of places (mainly legacy templates) where the link text was a meaningless value, the attribute was swapped out for aria-label, which reliably overides the link text readout.

Props rianrietveld

File:

• trunk/src/bp-groups/bp-groups-notifications.php (modified) (6 diffs)

trunk/src/bp-groups/bp-groups-notifications.php

@@ -394 +394 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . 's_notification', '<a href="' . $notification_link . '" title="' . __( 'Group Membership Requests', 'buddypress' ) . '">' . $text . '</a>', $group_link, $total_items, $group->name, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . 's_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $group_link, $total_items, $group->name, $text, $notification_link );
                 } else {
 
@@ -492 +492 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Groups', 'buddypress' ) . '">' . $text . '</a>', $total_items, $group->name, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $group->name, $text, $notification_link );
                 } else {
 
@@ -581 +581 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Groups', 'buddypress' ) . '">' . $text . '</a>', $total_items, $group->name );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $group->name );
                 } else {
 
@@ -667 +667 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Groups', 'buddypress' ) . '">' . $text . '</a>', $total_items, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $text, $notification_link );
                 } else {
                     /**
@@ -749 +749 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Groups', 'buddypress' ) . '">' . $text . '</a>', $total_items, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $text, $notification_link );
                 } else {
                     /**
@@ -831 +831 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Group Invites', 'buddypress' ) . '">' . $text . '</a>', $total_items, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $text, $notification_link );
                 } else {
                     /**