Changeset 11606 for trunk/src/bp-forums/bp-forums-template.php

Timestamp:

06/22/2017 08:09:27 PM (8 years ago)

Author:

djpaul

Message:

HTML <a> elements should never have title attributes.

Accessible support is too inconsistent across software and platforms.
In a small number of places (mainly legacy templates) where the link text was a meaningless value, the attribute was swapped out for aria-label, which reliably overides the link text readout.

Props rianrietveld

File:

• trunk/src/bp-forums/bp-forums-template.php (modified) (1 diff)

trunk/src/bp-forums/bp-forums-template.php

@@ -2653 +2653 @@
          * @param string $value HTML link for the poster's name.
          */
-        return apply_filters( 'bp_get_the_topic_post_poster_name', '<a href="' . $link . '" title="' . $topic_template->post->poster_name . '">' . $topic_template->post->poster_name . '</a>' );
+        return apply_filters( 'bp_get_the_topic_post_poster_name', '<a href="' . esc_url( $link ) . '">' . esc_html( $topic_template->post->poster_name ) . '</a>' );
     }