Changeset 11606 for trunk/src/bp-activity/bp-activity-notifications.php

Timestamp:

06/22/2017 08:09:27 PM (8 years ago)

Author:

djpaul

Message:

HTML <a> elements should never have title attributes.

Accessible support is too inconsistent across software and platforms.
In a small number of places (mainly legacy templates) where the link text was a meaningless value, the attribute was swapped out for aria-label, which reliably overides the link text readout.

Props rianrietveld

File:

• trunk/src/bp-activity/bp-activity-notifications.php (modified) (1 diff)

trunk/src/bp-activity/bp-activity-notifications.php

@@ -95 +95 @@
          * @param int    $user_id         ID of the user who inited the interaction.
          */
-        $return = apply_filters( 'bp_activity_' . $amount . '_' . $action_filter . '_notification', '<a href="' . esc_url( $link ) . '" title="' . esc_attr( $title ) . '">' . esc_html( $text ) . '</a>', $link, (int) $total_items, $activity_id, $user_id );
+        $return = apply_filters( 'bp_activity_' . $amount . '_' . $action_filter . '_notification', '<a href="' . esc_url( $link ) . '">' . esc_html( $text ) . '</a>', $link, (int) $total_items, $activity_id, $user_id );
     } else {