Changeset 11606

Timestamp:

06/22/2017 08:09:27 PM (7 years ago)

Author:

djpaul

Message:

HTML <a> elements should never have title attributes.

Accessible support is too inconsistent across software and platforms.
In a small number of places (mainly legacy templates) where the link text was a meaningless value, the attribute was swapped out for aria-label, which reliably overides the link text readout.

Props rianrietveld

Location:

trunk/src

Files:

• bp-activity/bp-activity-notifications.php (modified) (1 diff)
• bp-activity/classes/class-bp-activity-list-table.php (modified) (2 diffs)
• bp-core/admin/bp-core-admin-settings.php (modified) (1 diff)
• bp-core/classes/class-bp-core-user.php (modified) (1 diff)
• bp-forums/bp-forums-template.php (modified) (1 diff)
• bp-groups/bp-groups-notifications.php (modified) (6 diffs)
• bp-groups/classes/class-bp-groups-invite-template.php (modified) (1 diff)
• bp-members/classes/class-bp-members-list-table.php (modified) (1 diff)
• bp-members/classes/class-bp-members-ms-list-table.php (modified) (1 diff)
• bp-messages/bp-messages-notifications.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress-functions.php (modified) (4 diffs)
• bp-templates/bp-legacy/buddypress/forums/forums-loop.php (modified) (2 diffs)
• bp-templates/bp-legacy/buddypress/groups/single/admin/manage-members.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress/groups/single/cover-image-header.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress/groups/single/forum/topic.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress/members/single/messages/message.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress/members/single/messages/notices-loop.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress/members/single/messages/single.php (modified) (1 diff)
• bp-templates/bp-legacy/buddypress/members/single/settings/general.php (modified) (1 diff)
• bp-templates/bp-legacy/js/buddypress.js (modified) (1 diff)

trunk/src/bp-activity/bp-activity-notifications.php

@@ -95 +95 @@
          * @param int    $user_id         ID of the user who inited the interaction.
          */
-        $return = apply_filters( 'bp_activity_' . $amount . '_' . $action_filter . '_notification', '<a href="' . esc_url( $link ) . '" title="' . esc_attr( $title ) . '">' . esc_html( $text ) . '</a>', $link, (int) $total_items, $activity_id, $user_id );
+        $return = apply_filters( 'bp_activity_' . $amount . '_' . $action_filter . '_notification', '<a href="' . esc_url( $link ) . '">' . esc_html( $text ) . '</a>', $link, (int) $total_items, $activity_id, $user_id );
     } else {
 

trunk/src/bp-activity/classes/class-bp-activity-list-table.php

@@ -593 +593 @@
                 $actions['reply'] = sprintf( '<a href="#" class="reply hide-if-no-js">%s</a>', __( 'Reply', 'buddypress' ) );
             } else {
-                $actions['reply'] = sprintf( '<span class="form-input-tip" title="%s">%s</span>', __( 'Replies are disabled for this activity item', 'buddypress' ), __( 'Replies disabled', 'buddypress' ) );
+                $actions['reply'] = sprintf( '<span class="form-input-tip">%s</span>', __( 'Replies disabled', 'buddypress' ) );
             }
 
@@ -707 +707 @@
             // If the activity has comments, display a link to the activity's permalink, with its comment count in a speech bubble.
             if ( $comment_count ) {
-                $title_attr = sprintf( _n( '%s related activity', '%s related activities', $comment_count, 'buddypress' ), number_format_i18n( $comment_count ) );
-                printf( '<a href="%1$s" title="%2$s" class="post-com-count post-com-count-approved"><span class="comment-count comment-count-approved">%3$s</span></a>', esc_url( $root_activity_url ), esc_attr( $title_attr ), number_format_i18n( $comment_count ) );
+                printf( '<a href="%1$s" class="post-com-count post-com-count-approved"><span class="comment-count comment-count-approved">%2$s</span></a>', esc_url( $root_activity_url ), number_format_i18n( $comment_count ) );
             }
 

trunk/src/bp-core/admin/bp-core-admin-settings.php

@@ -272 +272 @@
     <?php if ( false === $file_exists ) : ?>
 
-        <a class="button" href="<?php bp_admin_url( 'admin.php?page=bb-forums-setup&repair=1' ); ?>" title="<?php esc_attr_e( 'Attempt to save a new config file.', 'buddypress' ); ?>"><?php _e( 'Repair', 'buddypress' ) ?></a>
+        <a class="button" href="<?php bp_admin_url( 'admin.php?page=bb-forums-setup&repair=1' ); ?>"><?php _e( 'Repair', 'buddypress' ) ?></a>
         <span class="attention"><?php _e( 'File does not exist', 'buddypress' ); ?></span>
 

trunk/src/bp-core/classes/class-bp-core-user.php

@@ -158 +158 @@
             $this->user_url  = bp_core_get_user_domain( $this->id, $this->profile_data['user_nicename'], $this->profile_data['user_login'] );
             $this->fullname  = esc_attr( $this->profile_data[$full_name_field_name]['field_data'] );
-            $this->user_link = "<a href='{$this->user_url}' title='{$this->fullname}'>{$this->fullname}</a>";
+            $this->user_link = "<a href='{$this->user_url}'>{$this->fullname}</a>";
             $this->email     = esc_attr( $this->profile_data['user_email'] );
         } else {

trunk/src/bp-forums/bp-forums-template.php

@@ -2653 +2653 @@
          * @param string $value HTML link for the poster's name.
          */
-        return apply_filters( 'bp_get_the_topic_post_poster_name', '<a href="' . $link . '" title="' . $topic_template->post->poster_name . '">' . $topic_template->post->poster_name . '</a>' );
+        return apply_filters( 'bp_get_the_topic_post_poster_name', '<a href="' . esc_url( $link ) . '">' . esc_html( $topic_template->post->poster_name ) . '</a>' );
     }
 

trunk/src/bp-groups/bp-groups-notifications.php

@@ -394 +394 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . 's_notification', '<a href="' . $notification_link . '" title="' . __( 'Group Membership Requests', 'buddypress' ) . '">' . $text . '</a>', $group_link, $total_items, $group->name, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . 's_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $group_link, $total_items, $group->name, $text, $notification_link );
                 } else {
 
@@ -492 +492 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Groups', 'buddypress' ) . '">' . $text . '</a>', $total_items, $group->name, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $group->name, $text, $notification_link );
                 } else {
 
@@ -581 +581 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Groups', 'buddypress' ) . '">' . $text . '</a>', $total_items, $group->name );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $group->name );
                 } else {
 
@@ -667 +667 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Groups', 'buddypress' ) . '">' . $text . '</a>', $total_items, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $text, $notification_link );
                 } else {
                     /**
@@ -749 +749 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Groups', 'buddypress' ) . '">' . $text . '</a>', $total_items, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $text, $notification_link );
                 } else {
                     /**
@@ -831 +831 @@
                      * @param string $notification_link The permalink for notification.
                      */
-                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '" title="' . __( 'Group Invites', 'buddypress' ) . '">' . $text . '</a>', $total_items, $text, $notification_link );
+                    return apply_filters( 'bp_groups_' . $amount . '_' . $action . '_notification', '<a href="' . $notification_link . '">' . $text . '</a>', $total_items, $text, $notification_link );
                 } else {
                     /**

trunk/src/bp-groups/classes/class-bp-groups-invite-template.php

@@ -237 +237 @@
         $this->invite->user->email        = $this->invite->user->user_email;
         $this->invite->user->user_url     = bp_core_get_user_domain( $user_id, $this->invite->user->user_nicename, $this->invite->user->user_login );
-        $this->invite->user->user_link    = "<a href='{$this->invite->user->user_url}' title='{$this->invite->user->fullname}'>{$this->invite->user->fullname}</a>";
+        $this->invite->user->user_link    = "<a href='{$this->invite->user->user_url}'>{$this->invite->user->fullname}</a>";
         $this->invite->user->last_active  = bp_core_get_last_activity( $this->invite->user->last_activity, __( 'active %s', 'buddypress' ) );
 

trunk/src/bp-members/classes/class-bp-members-list-table.php

@@ -309 +309 @@
         );
 
-        echo $avatar . sprintf( '<strong><a href="%1$s" class="edit" title="%2$s">%3$s</a></strong><br/>', esc_url( $activate_link ), esc_attr__( 'Activate', 'buddypress' ), $signup_object->user_login );
+        echo $avatar . sprintf( '<strong><a href="%1$s" class="edit">%2$s</a></strong><br/>', esc_url( $activate_link ), $signup_object->user_login );
 
         $actions = array();

trunk/src/bp-members/classes/class-bp-members-ms-list-table.php

@@ -302 +302 @@
         );
 
-        echo $avatar . sprintf( '<strong><a href="%1$s" class="edit" title="%2$s">%3$s</a></strong><br/>', esc_url( $activate_link ), esc_attr__( 'Activate', 'buddypress' ), $signup_object->user_login );
+        echo $avatar . sprintf( '<strong><a href="%1$s" class="edit">%2$s</a></strong><br/>', esc_url( $activate_link ), $signup_object->user_login );
 
         $actions = array();

trunk/src/bp-messages/bp-messages-notifications.php

@@ -54 +54 @@
         if ( 'string' === $format ) {
             if ( ! empty( $link ) ) {
-                $return = '<a href="' . esc_url( $link ) . '" title="' . esc_attr( $title ) . '">' . esc_html( $text ) . '</a>';
+                $return = '<a href="' . esc_url( $link ) . '">' . esc_html( $text ) . '</a>';
             } else {
                 $return = esc_html( $text );

trunk/src/bp-templates/bp-legacy/buddypress-functions.php

@@ -1496 +1496 @@
                 _e( 'Error joining group', 'buddypress' );
             } else {
-                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button leave-group" rel="leave" title="' . __( 'Leave Group', 'buddypress' ) . '" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'leave-group', 'groups_leave_group' ) . '">' . __( 'Leave Group', 'buddypress' ) . '</a>';
+                echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button leave-group" rel="leave" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'leave-group', 'groups_leave_group' ) . '">' . __( 'Leave Group', 'buddypress' ) . '</a>';
             }
 
@@ -1509 +1509 @@
                     _e( 'Error requesting membership', 'buddypress' );
                 } else {
-                    echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button leave-group" rel="leave" title="' . __( 'Leave Group', 'buddypress' ) . '" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'leave-group', 'groups_leave_group' ) . '">' . __( 'Leave Group', 'buddypress' ) . '</a>';
+                    echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button leave-group" rel="leave" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'leave-group', 'groups_leave_group' ) . '">' . __( 'Leave Group', 'buddypress' ) . '</a>';
                 }
 
@@ -1519 +1519 @@
                     _e( 'Error requesting membership', 'buddypress' );
                 } else {
-                    echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button disabled pending membership-requested" rel="membership-requested" title="' . __( 'Request Sent', 'buddypress' ) . '" href="' . bp_get_group_permalink( $group ) . '">' . __( 'Request Sent', 'buddypress' ) . '</a>';
+                    echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button disabled pending membership-requested" rel="membership-requested" href="' . bp_get_group_permalink( $group ) . '">' . __( 'Request Sent', 'buddypress' ) . '</a>';
                 }
             }
@@ -1530 +1530 @@
             _e( 'Error leaving group', 'buddypress' );
         } elseif ( 'public' == $group->status ) {
-            echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button join-group" rel="join" title="' . __( 'Join Group', 'buddypress' ) . '" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'join', 'groups_join_group' ) . '">' . __( 'Join Group', 'buddypress' ) . '</a>';
+            echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button join-group" rel="join" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'join', 'groups_join_group' ) . '">' . __( 'Join Group', 'buddypress' ) . '</a>';
         } elseif ( 'private' == $group->status ) {
-            echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button request-membership" rel="join" title="' . __( 'Request Membership', 'buddypress' ) . '" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'request-membership', 'groups_request_membership' ) . '">' . __( 'Request Membership', 'buddypress' ) . '</a>';
+            echo '<a id="group-' . esc_attr( $group->id ) . '" class="group-button request-membership" rel="join" href="' . wp_nonce_url( bp_get_group_permalink( $group ) . 'request-membership', 'groups_request_membership' ) . '">' . __( 'Request Membership', 'buddypress' ) . '</a>';
         }
     }

trunk/src/bp-templates/bp-legacy/buddypress/forums/forums-loop.php

@@ -72 +72 @@
             <tr class="<?php bp_the_topic_css_class(); ?>">
                 <td class="td-title">
-                    <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>" title="<?php esc_attr_e( 'Permanent link to this post', 'buddypress' ); ?>">
+                    <a class="topic-title" href="<?php bp_the_topic_permalink(); ?>">
 
                         <?php bp_the_topic_title(); ?>
@@ -87 +87 @@
                                 <?php
                                     $topic_in = '<a href="' . bp_get_the_topic_object_permalink() . '">' . bp_get_the_topic_object_avatar( 'type=thumb&width=20&height=20' ) . '</a>' .
-                                                    '<a href="' . bp_get_the_topic_object_permalink() . '" title="' . bp_get_the_topic_object_name() . '">' . bp_get_the_topic_object_name() .'</a>';
+                                                    '<a href="' . bp_get_the_topic_object_permalink() . '">' . bp_get_the_topic_object_name() .'</a>';
 
                                     /* translators: "started by [poster] in [forum]" */

trunk/src/bp-templates/bp-legacy/buddypress/groups/single/admin/manage-members.php

@@ -268 +268 @@
                             <?php if ( bp_get_group_member_is_banned() ) : ?>
 
-                                <a href="<?php bp_group_member_unban_link(); ?>" class="button confirm member-unban" title="<?php esc_attr_e( 'Unban this member', 'buddypress' ); ?>"><?php _e( 'Remove Ban', 'buddypress' ); ?></a>
+                                <a href="<?php bp_group_member_unban_link(); ?>" class="button confirm member-unban"><?php _e( 'Remove Ban', 'buddypress' ); ?></a>
 
                             <?php else : ?>

trunk/src/bp-templates/bp-legacy/buddypress/groups/single/cover-image-header.php

@@ -20 +20 @@
         <?php if ( ! bp_disable_group_avatar_uploads() ) : ?>
             <div id="item-header-avatar">
-                <a href="<?php echo esc_url( bp_get_group_permalink() ); ?>" title="<?php echo esc_attr( bp_get_group_name() ); ?>">
+                <a href="<?php echo esc_url( bp_get_group_permalink() ); ?>">
 
                     <?php bp_group_avatar(); ?>

trunk/src/bp-templates/bp-legacy/buddypress/groups/single/forum/topic.php

@@ -127 +127 @@
                         do_action( 'bp_group_forum_post_meta' ); ?>
 
-                        <a href="#post-<?php bp_the_topic_post_id(); ?>" title="<?php esc_attr_e( 'Permanent link to this post', 'buddypress' ); ?>">#</a>
+                        <a href="#post-<?php bp_the_topic_post_id(); ?>" aria-label="<?php esc_attr_e( 'Permanent link to this post', 'buddypress' ); ?>">#</a>
                     </div>
                 </li>

trunk/src/bp-templates/bp-legacy/buddypress/members/single/messages/message.php

@@ -31 +31 @@
                     <?php if ( bp_get_the_thread_message_sender_link() ) : ?>
 
-                        <strong><a href="<?php bp_the_thread_message_sender_link(); ?>" title="<?php bp_the_thread_message_sender_name(); ?>"><?php bp_the_thread_message_sender_name(); ?></a></strong>
+                        <strong><a href="<?php bp_the_thread_message_sender_link(); ?>"><?php bp_the_thread_message_sender_name(); ?></a></strong>
 
                     <?php else : ?>

trunk/src/bp-templates/bp-legacy/buddypress/members/single/messages/notices-loop.php

@@ -75 +75 @@
                 <td width="10%">
                     <a class="button" href="<?php bp_message_activate_deactivate_link(); ?>" class="confirm"><?php bp_message_activate_deactivate_text(); ?></a>
-                    <a class="button" href="<?php bp_message_notice_delete_link(); ?>" class="confirm" title="<?php esc_attr_e( "Delete Message", 'buddypress' ); ?>">x</a>
+                    <a class="button" href="<?php bp_message_notice_delete_link(); ?>" class="confirm" aria-label="<?php esc_attr_e( "Delete Message", 'buddypress' ); ?>">x</a>
                 </td>
             </tr>

trunk/src/bp-templates/bp-legacy/buddypress/members/single/messages/single.php

@@ -42 +42 @@
             </span>
 
-            <a class="button confirm" href="<?php bp_the_thread_delete_link(); ?>" title="<?php esc_attr_e( "Delete Conversation", 'buddypress' ); ?>"><?php _e( 'Delete', 'buddypress' ); ?></a>
+            <a class="button confirm" href="<?php bp_the_thread_delete_link(); ?>"><?php _e( 'Delete', 'buddypress' ); ?></a>
 
             <?php

trunk/src/bp-templates/bp-legacy/buddypress/members/single/settings/general.php

@@ -20 +20 @@
 
         <label for="pwd"><?php _e( 'Current Password <span>(required to update email or change current password)</span>', 'buddypress' ); ?></label>
-        <input type="password" name="pwd" id="pwd" size="16" value="" class="settings-input small" <?php bp_form_field_attributes( 'password' ); ?>/> &nbsp;<a href="<?php echo wp_lostpassword_url(); ?>" title="<?php esc_attr_e( 'Password Lost and Found', 'buddypress' ); ?>"><?php _e( 'Lost your password?', 'buddypress' ); ?></a>
+        <input type="password" name="pwd" id="pwd" size="16" value="" class="settings-input small" <?php bp_form_field_attributes( 'password' ); ?>/> &nbsp;<a href="<?php echo wp_lostpassword_url(); ?>"><?php _e( 'Lost your password?', 'buddypress' ); ?></a>
 
     <?php endif; ?>

trunk/src/bp-templates/bp-legacy/js/buddypress.js

@@ -1975 +1975 @@
 
                 if ( !i ) {
-                    jq(this).before( '<li class="show-all"><a href="#' + parent_li.attr('id') + '/show-all/" title="' + BP_DTheme.show_all_comments + '">' + BP_DTheme.show_x_comments.replace( '%d', comment_count ) + '</a></li>' );
+                    jq(this).before( '<li class="show-all"><a href="#' + parent_li.attr('id') + '/show-all/">' + BP_DTheme.show_x_comments.replace( '%d', comment_count ) + '</a></li>' );
                 }
             }