Changeset 11582 for trunk/src/bp-messages/bp-messages-template.php

Timestamp:

06/08/2017 06:36:43 PM (9 years ago)

Author:

mercime

Message:

Accessibility: Change empty link in Sitewide Notice to a button element.

Using semantic markup like the button element instead of an empty anchor link
like href=# in this case, helps us improve accessibility for all users.

Props mercime, slaFFik, johnjamesjacoby.
Fixes #7421.

File:

• trunk/src/bp-messages/bp-messages-template.php (modified) (1 diff)

trunk/src/bp-messages/bp-messages-template.php

@@ -1278 +1278 @@
                     <strong><?php echo stripslashes( wp_filter_kses( $notice->subject ) ) ?></strong><br />
                     <?php echo stripslashes( wp_filter_kses( $notice->message) ) ?>
-                    <a href="#" id="close-notice"><?php _e( 'Close', 'buddypress' ) ?></a>
+                    <button type="button" id="close-notice" class="bp-tooltip" data-bp-tooltip="<?php esc_attr_e( 'Dismiss this notice', 'buddypress' ) ?>"><span class="bp-screen-reader-text"><?php _e( 'Dismiss this notice', 'buddypress' ) ?>"></span> <span aria-hidden="true">&Chi;</span></button>
                     <?php wp_nonce_field( 'bp_messages_close_notice', 'close-notice-nonce' ); ?>
                 </p>